Issue 10909169: Add support for WritableRegister policy in the register allocator.

Issue 10909169: Add support for WritableRegister policy in the register allocator. (Closed)

Created:
8 years, 3 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 3 months ago

Reviewers:
Florian Schneider, fschneider, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for WritableRegister policy in the register allocator. Use it to eliminate push/pop on the fast path of the write barrier. Tighten assertions in StoreIntoObject to ensure that value register is not equal to object register. Current code can't cope with that. BUG= Committed: https://code.google.com/p/dart/source/detail?r=12193

Patch Set 1 #

Total comments: 14

Patch Set 2 : remove debugging assertions from StoreIntoObject on x64 #

Patch Set 3 : revert all formatting changes. #

Patch Set 4 : Don't use non-volatile EBX in a test #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -46 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View		1 chunk	+32 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	1 chunk	+8 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	4 chunks	+7 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	4 chunks	+14 lines, -17 lines	0 comments	Download
M	runtime/vm/locations.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/locations.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

There seem to be quite a few unneeded changes... -Ivan https://chromiumcodereview.appspot.com/10909169/diff/1/runtime/vm/assembler_x64.cc File runtime/vm/assembler_x64.cc (right): https://chromiumcodereview.appspot.com/10909169/diff/1/runtime/vm/assembler_x64.cc#newcode1609 ...

8 years, 3 months ago (2012-09-11 11:57:30 UTC) #2

Vyacheslav Egorov (Google)

I reverted all accidental formatting changes (caused during developement: StoreIntoObject was accepting a boolean flag ...

8 years, 3 months ago (2012-09-11 12:18:04 UTC) #3

Thanks for the review. 

Landing.

Expand Messages | Collapse Messages