Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 10909169: Add support for WritableRegister policy in the register allocator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Don't use non-volatile EBX in a test Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
diff --git a/runtime/vm/assembler_ia32.cc b/runtime/vm/assembler_ia32.cc
index dbba71ba15573a8d6a528d576e198817b8a2834a..807401c589f29d357eda86c58df69c4b60a17f2f 100644
--- a/runtime/vm/assembler_ia32.cc
+++ b/runtime/vm/assembler_ia32.cc
@@ -1422,10 +1422,9 @@ void Assembler::StoreIntoObjectFilter(Register object,
void Assembler::StoreIntoObject(Register object,
const FieldAddress& dest,
Register value) {
- // TODO(kmillikin): pass temp registers to avoid pushing registers.
+ ASSERT(object != value);
movl(dest, value);
Label done;
- pushl(value);
StoreIntoObjectFilter(object, value, &done);
// A store buffer update is required.
if (value != EAX) pushl(EAX); // Preserve EAX.
@@ -1433,7 +1432,6 @@ void Assembler::StoreIntoObject(Register object,
call(&StubCode::UpdateStoreBufferLabel());
if (value != EAX) popl(EAX); // Restore EAX.
Bind(&done);
- popl(value);
}
« no previous file with comments | « no previous file | runtime/vm/assembler_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698