Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10909169: Add support for WritableRegister policy in the register allocator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 888 matching lines...) Expand 10 before | Expand all | Expand 10 after
899 } 899 }
900 900
901 901
902 void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) { 902 void FlowGraphCompiler::GenerateInlinedSetter(intptr_t offset) {
903 // TOS: return address. 903 // TOS: return address.
904 // +1 : value 904 // +1 : value
905 // +2 : receiver. 905 // +2 : receiver.
906 // Sequence node has one store node and one return NULL node. 906 // Sequence node has one store node and one return NULL node.
907 __ movl(EAX, Address(ESP, 2 * kWordSize)); // Receiver. 907 __ movl(EAX, Address(ESP, 2 * kWordSize)); // Receiver.
908 __ movl(EBX, Address(ESP, 1 * kWordSize)); // Value. 908 __ movl(EBX, Address(ESP, 1 * kWordSize)); // Value.
909 __ StoreIntoObject(EAX, FieldAddress(EAX, offset), EBX); 909 __ StoreIntoObject(EAX,
Ivan Posva 2012/09/11 11:57:30 Why this change?
Vyacheslav Egorov (Google) 2012/09/11 12:18:05 Initially I was also passing additional argument,
910 FieldAddress(EAX, offset),
911 EBX);
910 const Immediate raw_null = 912 const Immediate raw_null =
911 Immediate(reinterpret_cast<intptr_t>(Object::null())); 913 Immediate(reinterpret_cast<intptr_t>(Object::null()));
912 __ movl(EAX, raw_null); 914 __ movl(EAX, raw_null);
913 __ ret(); 915 __ ret();
914 } 916 }
915 917
916 918
917 void FlowGraphCompiler::GenerateInlinedMathSqrt(Label* done) { 919 void FlowGraphCompiler::GenerateInlinedMathSqrt(Label* done) {
918 Label smi_to_double, double_op, call_method; 920 Label smi_to_double, double_op, call_method;
919 __ movl(EAX, Address(ESP, 0)); 921 __ movl(EAX, Address(ESP, 0));
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1380 __ popl(ECX); 1382 __ popl(ECX);
1381 __ popl(EAX); 1383 __ popl(EAX);
1382 } 1384 }
1383 1385
1384 1386
1385 #undef __ 1387 #undef __
1386 1388
1387 } // namespace dart 1389 } // namespace dart
1388 1390
1389 #endif // defined TARGET_ARCH_IA32 1391 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698