Support checked mode for field setters.

Support checked mode for field setters.

[ngeoffray, 2012-08-30 12:51:55]

Note that this is not enough for full checked mode, still missing are: checks in
the generative constructor, and checks with HFieldSet.

[floitsch, 2012-08-30 14:35:14]

LGTM.

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/el...
File lib/compiler/implementation/elements/elements.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/el...
lib/compiler/implementation/elements/elements.dart:737:
compiler.withCurrentElement(this, () {
Is this still necessary?

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/en...
File lib/compiler/implementation/enqueue.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/en...
lib/compiler/implementation/enqueue.dart:168: if (member.kind ===
ElementKind.FIELD) {
if (member.isField()) {

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/en...
lib/compiler/implementation/enqueue.dart:204: } else if (member.kind ==
ElementKind.GETTER) {
member.isGetter()

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
File lib/compiler/implementation/js_backend/emitter.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
lib/compiler/implementation/js_backend/emitter.dart:439: if (type.element.kind
== ElementKind.TYPE_VARIABLE
type.element.isTypeVariable()

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/codegen.dart:2339: Type type =
node.type.computeType(compiler);
Add Element element = type.element;
It's used frequently below.

[kasperl, 2012-08-30 14:36:08]

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
File lib/compiler/implementation/js_backend/backend.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
lib/compiler/implementation/js_backend/backend.dart:552: SourceString helper;
Wouldn't it be simpler just to return instead of assigning to helper?

[ngeoffray, 2012-08-30 17:10:21]

Thanks Florian and Kasper

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/el...
File lib/compiler/implementation/elements/elements.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/el...
lib/compiler/implementation/elements/elements.dart:737:
compiler.withCurrentElement(this, () {
On 2012/08/30 14:35:14, floitsch wrote:
> Is this still necessary?

Good catch.

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/en...
File lib/compiler/implementation/enqueue.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/en...
lib/compiler/implementation/enqueue.dart:168: if (member.kind ===
ElementKind.FIELD) {
On 2012/08/30 14:35:14, floitsch wrote:
> if (member.isField()) {

I kept the original style of this method, which uses kinds.

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/en...
lib/compiler/implementation/enqueue.dart:204: } else if (member.kind ==
ElementKind.GETTER) {
On 2012/08/30 14:35:14, floitsch wrote:
> member.isGetter()

Ditto

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
File lib/compiler/implementation/js_backend/backend.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
lib/compiler/implementation/js_backend/backend.dart:552: SourceString helper;
On 2012/08/30 14:36:08, kasperl wrote:
> Wouldn't it be simpler just to return instead of assigning to helper?

Done.

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
File lib/compiler/implementation/js_backend/emitter.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/js...
lib/compiler/implementation/js_backend/emitter.dart:439: if (type.element.kind
== ElementKind.TYPE_VARIABLE
On 2012/08/30 14:35:14, floitsch wrote:
> type.element.isTypeVariable()

Done.

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/ss...
File lib/compiler/implementation/ssa/codegen.dart (right):

http://codereview.chromium.org/10908012/diff/1/lib/compiler/implementation/ss...
lib/compiler/implementation/ssa/codegen.dart:2339: Type type =
node.type.computeType(compiler);
On 2012/08/30 14:35:14, floitsch wrote:
> Add Element element = type.element;
> It's used frequently below.

Done.

[ahe, 2012-08-31 09:46:51]

DBC

https://chromiumcodereview.appspot.com/10908012/diff/9001/lib/compiler/implem...
File lib/compiler/implementation/enqueue.dart (right):

https://chromiumcodereview.appspot.com/10908012/diff/9001/lib/compiler/implem...
lib/compiler/implementation/enqueue.dart:170: if (compiler.enableTypeAssertions)
{
This doesn't feel like the right place for this.

https://chromiumcodereview.appspot.com/10908012/diff/9001/lib/compiler/implem...
lib/compiler/implementation/enqueue.dart:173: SourceString helper =
compiler.backend.getCheckedModeHelper(type);
And this is feeling even wronger :-)

[ngeoffray, 2012-09-05 13:00:29]

https://chromiumcodereview.appspot.com/10908012/diff/9001/lib/compiler/implem...
File lib/compiler/implementation/enqueue.dart (right):

https://chromiumcodereview.appspot.com/10908012/diff/9001/lib/compiler/implem...
lib/compiler/implementation/enqueue.dart:173: SourceString helper =
compiler.backend.getCheckedModeHelper(type);
On 2012/08/31 09:46:51, ahe wrote:
> And this is feeling even wronger :-)

Agree. Fix is in https://chromiumcodereview.appspot.com/10910088/.