Support checked mode for field setters.

lib/compiler/implementation/enqueue.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class EnqueueTask extends CompilerTask {
   final Enqueuer codegen;
   final Enqueuer resolution;
 
   String get name => 'Enqueue';
 
@@ skipping 145 matching lines @@
     return true;
   }
 
   void processInstantiatedClass(ClassElement cls) {
     cls.localMembers.forEach(processInstantiatedClassMember);
   }
 
   void processInstantiatedClassMember(Element member) {
     if (universe.generatedCode.containsKey(member)) return;
     if (resolvedElements[member] !== null) return;
+    if (!member.isInstanceMember()) return;
 
-    if (!member.isInstanceMember()) return;
-    if (member.isField()) return;
+    if (member.kind === ElementKind.FIELD) {
+      universe.instantiatedClassInstanceFields.add(member.name);
+      if (compiler.enableTypeAssertions) {

[ahe, 2012/08/31 09:46:51]

This doesn't feel like the right place for this.

+        Type type = member.computeType(compiler);
+        registerIsCheck(type.element);
+        SourceString helper = compiler.backend.getCheckedModeHelper(type);

[ahe, 2012/08/31 09:46:51]

And this is feeling even wronger :-)

[ngeoffray, 2012/09/05 13:00:29]

Agree. Fix is in https://chromiumcodereview.appspot.com/10910088/.

+        if (helper != null) {
+          Element helperElement = compiler.findHelper(helper);
+          registerStaticUse(helperElement);
+        }
+      }  
+      return;
+    }
 
     String memberName = member.name.slowToString();
     Link<Element> members = instanceMembersByName.putIfAbsent(
         memberName, () => const EmptyLink<Element>());
     instanceMembersByName[memberName] = members.prepend(member);
 
-    if (member.kind === ElementKind.GETTER ||
-        member.kind === ElementKind.FIELD) {
-      universe.instantiatedClassInstanceFields.add(member.name);
-    }
 
     if (member.kind == ElementKind.FUNCTION) {
       if (member.name == Compiler.NO_SUCH_METHOD) {
         compiler.enableNoSuchMethod(member);
       }
       if (universe.hasInvocation(member, compiler)) {
         return addToWorkList(member);
       }
       // If there is a property access with the same name as a method we
       // need to emit the method.
       if (universe.hasInvokedGetter(member, compiler)) {
         // We will emit a closure, so make sure the closure class is
         // generated.
         compiler.closureClass.ensureResolved(compiler);
         registerInstantiatedClass(compiler.closureClass);
         return addToWorkList(member);
       }
     } else if (member.kind == ElementKind.GETTER) {
+      universe.instantiatedClassInstanceFields.add(member.name);
       if (universe.hasInvokedGetter(member, compiler)) {
         return addToWorkList(member);
       }
       // We don't know what selectors the returned closure accepts. If
       // the set contains any selector we have to assume that it matches.
       if (universe.hasInvocation(member, compiler)) {
         return addToWorkList(member);
       }
     } else if (member.kind === ElementKind.SETTER) {
       if (universe.hasInvokedSetter(member, compiler)) {
@@ skipping 131 matching lines @@
   void registerIsCheck(Element element) {
     universe.isChecks.add(element);
   }
 
   void forEach(f(WorkItem work)) {
     while (!queue.isEmpty()) {
       f(queue.removeLast()); // TODO(kasperl): Why isn't this removeFirst?
     }
   }
 }