Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10890030: Move core and coreimpl from corelib/ to lib/core and lib/coreimpl. (Closed)

Created:
8 years, 3 months ago by Anders Johnsen
Modified:
8 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move core and coreimpl from corelib/ to lib/core and lib/coreimpl. BUG= Committed: https://code.google.com/p/dart/source/detail?r=11606

Patch Set 1 #

Patch Set 2 : Re-introduce correct analyzer code. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -5168 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CoreTypeProvider.java View 1 chunk +0 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/CoreTypeProviderImplementation.java View 1 5 chunks +1 line, -37 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Elements.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTestCase.java View 1 chunk +0 lines, -25 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTestCase.java View 4 chunks +0 lines, -25 lines 0 comments Download
D corelib/src/bool.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D corelib/src/collection.dart View 1 chunk +0 lines, -68 lines 0 comments Download
D corelib/src/comparable.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D corelib/src/corelib_sources.gypi View 1 chunk +0 lines, -38 lines 0 comments Download
D corelib/src/date.dart View 1 chunk +0 lines, -217 lines 0 comments Download
D corelib/src/double.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D corelib/src/duration.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D corelib/src/errors.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D corelib/src/exceptions.dart View 1 2 1 chunk +0 lines, -205 lines 0 comments Download
D corelib/src/expando.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D corelib/src/expect.dart View 1 2 1 chunk +0 lines, -292 lines 0 comments Download
D corelib/src/function.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D corelib/src/future.dart View 1 chunk +0 lines, -228 lines 0 comments Download
D corelib/src/hashable.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D corelib/src/implementation/arrays.dart View 1 2 1 chunk +0 lines, -93 lines 0 comments Download
D corelib/src/implementation/collections.dart View 1 chunk +0 lines, -155 lines 0 comments Download
D corelib/src/implementation/corelib_impl_sources.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
D corelib/src/implementation/date.dart View 1 chunk +0 lines, -184 lines 0 comments Download
D corelib/src/implementation/dual_pivot_quicksort.dart View 1 chunk +0 lines, -342 lines 0 comments Download
D corelib/src/implementation/duration_implementation.dart View 1 chunk +0 lines, -74 lines 0 comments Download
D corelib/src/implementation/exceptions.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D corelib/src/implementation/expando.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D corelib/src/implementation/future_implementation.dart View 1 2 1 chunk +0 lines, -232 lines 0 comments Download
D corelib/src/implementation/hash_map_set.dart View 1 chunk +0 lines, -454 lines 0 comments Download
D corelib/src/implementation/linked_hash_map.dart View 1 chunk +0 lines, -121 lines 0 comments Download
D corelib/src/implementation/list.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D corelib/src/implementation/maps.dart View 1 chunk +0 lines, -113 lines 0 comments Download
D corelib/src/implementation/object.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D corelib/src/implementation/options.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D corelib/src/implementation/print.dart View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D corelib/src/implementation/queue.dart View 1 chunk +0 lines, -263 lines 0 comments Download
D corelib/src/implementation/regexp.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D corelib/src/implementation/splay_tree.dart View 1 chunk +0 lines, -306 lines 0 comments Download
D corelib/src/implementation/stopwatch_implementation.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D corelib/src/implementation/string.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D corelib/src/implementation/string_buffer.dart View 1 chunk +0 lines, -86 lines 0 comments Download
D corelib/src/int.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D corelib/src/iterable.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D corelib/src/iterator.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D corelib/src/list.dart View 1 chunk +0 lines, -156 lines 0 comments Download
D corelib/src/map.dart View 1 chunk +0 lines, -123 lines 0 comments Download
D corelib/src/num.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D corelib/src/object.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D corelib/src/options.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D corelib/src/pattern.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D corelib/src/print.dart View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
D corelib/src/queue.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D corelib/src/regexp.dart View 1 chunk +0 lines, -131 lines 0 comments Download
D corelib/src/set.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D corelib/src/stopwatch.dart View 1 chunk +0 lines, -66 lines 0 comments Download
D corelib/src/string.dart View 1 chunk +0 lines, -132 lines 0 comments Download
D corelib/src/string_buffer.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D corelib/src/strings.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/model/DartSdk.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/PackageLibraryManagerProviderAnyTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/server/VmConnection.java View 1 chunk +1 line, -1 line 0 comments Download
M lib/_internal/libraries.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/core.dart View 1 2 1 chunk +30 lines, -30 lines 0 comments Download
M lib/compiler/implementation/lib/coreimpl.dart View 1 chunk +21 lines, -21 lines 0 comments Download
M lib/config/import_any.config View 1 chunk +2 lines, -3 lines 0 comments Download
M lib/config/import_dartium.config View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/config/import_vm.config View 1 chunk +0 lines, -3 lines 0 comments Download
A + lib/core/bool.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/collection.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/comparable.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A lib/core/core.dart View 1 chunk +34 lines, -0 lines 0 comments Download
A + lib/core/corelib_sources.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/date.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/double.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/duration.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/errors.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/exceptions.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/expando.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/expect.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/function.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/future.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/hashable.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/int.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/iterable.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/iterator.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/map.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/num.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/object.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/options.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/pattern.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/print.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/queue.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/regexp.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/set.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/stopwatch.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/string.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/string_buffer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/core/strings.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/arrays.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/collections.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A lib/coreimpl/coreimpl.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A + lib/coreimpl/corelib_impl_sources.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/date.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/dual_pivot_quicksort.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/duration_implementation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/exceptions.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/expando.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/future_implementation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/hash_map_set.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/linked_hash_map.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/list.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/maps.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/object.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/options.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/print.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/queue.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/regexp.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/splay_tree.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/stopwatch_implementation.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/string.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + lib/coreimpl/string_buffer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/vm/vm.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/create_sdk.py View 5 chunks +3 lines, -108 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
This patch does the final move in the unification process. Since it depends on the ...
8 years, 3 months ago (2012-08-29 05:26:58 UTC) #1
Anders Johnsen
Konstantin: Can you look at the changes I did to the analyzer? I've removed some ...
8 years, 3 months ago (2012-08-29 05:31:13 UTC) #2
scheglov
On 2012/08/29 05:31:13, ajohnsen wrote: > Konstantin: Can you look at the changes I did ...
8 years, 3 months ago (2012-08-29 05:35:21 UTC) #3
Mads Ager (google)
8 years, 3 months ago (2012-08-29 08:17:21 UTC) #4
LGTM

Yay! Now I just need to actually do the print change so we can land this. :)

Powered by Google App Engine
This is Rietveld 408576698