Expose remaining 'errors' in an unified dart:core.

Expose remaining 'errors' in an unified dart:core.

This is a follow-up on my previous move of AssertionError.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=11513

[Mads Ager (google), 2012-08-28 15:16:51]

Can we use the same extends/implements scheme in both dart2js and VM?

https://chromiumcodereview.appspot.com/10896007/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/10896007/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mock.dart:9: class TypeErrorImplementation
extends TypeError {
Why are these in mock.dart?

Also, why is there the difference in extends/implements here and in the VM?

[Anders Johnsen, 2012-08-28 15:32:58]

PTAL

https://chromiumcodereview.appspot.com/10896007/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/10896007/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mock.dart:9: class TypeErrorImplementation
extends TypeError {
On 2012/08/28 15:16:51, Mads Ager wrote:
> Why are these in mock.dart?
> 
> Also, why is there the difference in extends/implements here and in the VM?

The questions is, where should they be. And I have no good answer for that.

Fixed so these also implements the exposed type.

[Mads Ager (google), 2012-08-28 16:01:46]

I'm wondering about whether or not the user should be allowed to create these.
He probably shouldn't. These are errors that the implementations generate and
maybe we should make it impossible for users to create them?

Overall, it is looking OK, but I don't really like it. I think we should just
have these types in corelib/src/errors.dart. They could have just a final
message field and a toString method. Then it would be up to the two
implementation to create the instances and put in the message strings.

https://chromiumcodereview.appspot.com/10896007/diff/4001/lib/compiler/implem...
File lib/compiler/implementation/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/10896007/diff/4001/lib/compiler/implem...
lib/compiler/implementation/lib/mock.dart:9: class TypeErrorImplementation
implements TypeError {
How about putting these in errors.dart. That will match the
corelib/src/errors.dart file.

[Mads Ager (google), 2012-08-29 07:46:52]

LGTM

Having thought about this some more I think this is the right thing to do at
first.

https://chromiumcodereview.appspot.com/10896007/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/10896007/diff/7001/lib/compiler/implem...
lib/compiler/implementation/lib/mock.dart:9: class TypeErrorImplementation
implements TypeError {
Move these out into errors.dart?

[Anders Johnsen, 2012-08-29 10:29:44]

https://chromiumcodereview.appspot.com/10896007/diff/7001/lib/compiler/implem...
File lib/compiler/implementation/lib/mock.dart (right):

https://chromiumcodereview.appspot.com/10896007/diff/7001/lib/compiler/implem...
lib/compiler/implementation/lib/mock.dart:9: class TypeErrorImplementation
implements TypeError {
On 2012/08/29 07:46:52, Mads Ager wrote:
> Move these out into errors.dart?

The vm extends these with non-private members, not doable with patching. What do
you think we should do?

[Anders Johnsen, 2012-08-29 11:52:45]

Understood now, PTAL.

[Mads Ager (google), 2012-08-29 11:54:39]

LGTM