Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10871071: - Change "static final" to "static const" in the tests/ directory. (Closed)

Created:
8 years, 4 months ago by Ivan Posva
Modified:
8 years, 4 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

- Change "static final" to "static const" in the tests/ directory. Committed: https://code.google.com/p/dart/source/detail?r=11350

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -461 lines) Patch
M tests/compiler/dart2js/array_static_intercept_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/boolified_operator_test.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/boolify_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/builtin_interceptor_test.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/call_site_type_inferer_static_test.dart View 1 1 chunk +10 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/call_site_type_inferer_test.dart View 1 9 chunks +13 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/class_codegen2_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/class_codegen_test.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/class_order_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/closure_codegen_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/code_motion_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/constant_folding_test.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/dead_phi_eliminator_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/field_codegen_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/generate_at_use_site_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/gvn_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/identity_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/is_inference2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/is_inference_test.dart View 1 5 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/literal_list_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/loop_test.dart View 1 6 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/no_constructor_body_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/no_duplicate_constructor_body2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/no_duplicate_constructor_body_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/null_type_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parameter_phi_elimination_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/pretty_parameter_test.dart View 1 4 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/redundant_phi_eliminator_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/return_type_inferer_test.dart View 1 3 chunks +10 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/rewrite_better_user_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/ssa_phi_codegen_test.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 1 1 chunk +21 lines, -21 lines 0 comments Download
M tests/compiler/dart2js/type_guard_unuser_test.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/type_inference2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference3_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference4_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference5_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_inference_test.dart View 1 4 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/unparser_test.dart View 1 9 chunks +12 lines, -12 lines 0 comments Download
M tests/compiler/dart2js_extra/compile_time_constant4_test.dart View 1 1 chunk +11 lines, -11 lines 0 comments Download
M tests/compiler/dart2js_extra/field_initializer_test.dart View 1 1 chunk +12 lines, -12 lines 0 comments Download
M tests/compiler/dart2js_extra/naming_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js_extra/simple_string_constant_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/collection_to_string_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/expando_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/indexeddb_1_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/indexeddb_2_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/indexeddb_3_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/indexeddb_4_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/js_interop_4_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/mandel_isolate_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/isolate/message_test.dart View 1 1 chunk +7 lines, -7 lines 0 comments Download
M tests/isolate/multiple_timer_test.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/isolate/timer_repeat_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/isolate/timer_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/compile_time_constant_k_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/language/const_init_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/const_syntax_test.dart View 3 chunks +17 lines, -17 lines 0 comments Download
D tests/language/final_syntax_test.dart View 1 1 chunk +0 lines, -75 lines 0 comments Download
M tests/language/function_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/inst_field_initializer_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/language/map_literal_test.dart View 1 2 chunks +6 lines, -6 lines 0 comments Download
A + tests/language/static_const_field_test.dart View 1 chunk +20 lines, -20 lines 0 comments Download
M tests/language/static_final_field2_negative_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/static_final_field_negative_test.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
D tests/language/static_final_field_test.dart View 1 1 chunk +0 lines, -54 lines 0 comments Download
M tests/language/static_top_level_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/crypto/hmac_sha1_test_vectors.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/crypto/hmac_sha256_test_vectors.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/lib/crypto/sha1_long_test_vectors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/crypto/sha1_short_test_vectors.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/crypto/sha256_long_test_vectors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/crypto/sha256_short_test_vectors.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/echo_server_stream_test.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/echo_server_test.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/fuzz_support.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_advanced_test.dart View 1 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/http_basic_test.dart View 1 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/http_read_test.dart View 1 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/socket_close_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_many_connections_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_stream_close_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/test_extension_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/testing_server.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/package/packages/package2.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
8 years, 4 months ago (2012-08-24 21:57:27 UTC) #1
hausner
8 years, 4 months ago (2012-08-24 22:13:32 UTC) #2 
LGTM with suggestion to rename two of the tests.

https://chromiumcodereview.appspot.com/10871071/diff/1/tests/language/static_...
File tests/language/static_final_field2_negative_test.dart (left):

https://chromiumcodereview.appspot.com/10871071/diff/1/tests/language/static_...
tests/language/static_final_field2_negative_test.dart:7: static final x = 1;
Maybe rename the test like you did for other tests that have the string "final"
in them?

https://chromiumcodereview.appspot.com/10871071/diff/1/tests/language/static_...
File tests/language/static_final_field_negative_test.dart (left):

https://chromiumcodereview.appspot.com/10871071/diff/1/tests/language/static_...
tests/language/static_final_field_negative_test.dart:4: // Dart test program for
testing static final fields.
Maybe rename the test?

Powered by Google App Engine
This is Rietveld 408576698