Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 10860007: Reland "Record the arguments for CreateArrayComp correctly as arguments.". (Closed)

Created:
8 years, 4 months ago by Florian Schneider
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Reland "Record the arguments for CreateArrayComp correctly as arguments.". This time on the correct branch. The elements are not real uses and are therefore not maintained accordingly. BUG=dart:4563 TBR=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=10884

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -22 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +7 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Florian Schneider
I accidentally committed the original CL on the trunk branch (r10879) and reverted it from ...
8 years, 4 months ago (2012-08-17 11:47:36 UTC) #1
Vyacheslav Egorov (Google)
8 years, 4 months ago (2012-08-17 11:52:18 UTC) #2
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698