Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10860007: Reland "Record the arguments for CreateArrayComp correctly as arguments.". (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 10878)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -1282,20 +1282,19 @@
void EffectGraphVisitor::VisitArrayNode(ArrayNode* node) {
// Translate the array elements and collect their values.
- ZoneGrowableArray<Value*>* values =
- new ZoneGrowableArray<Value*>(node->length());
+ ZoneGrowableArray<PushArgumentInstr*>* arguments =
+ new ZoneGrowableArray<PushArgumentInstr*>(node->length());
for (int i = 0; i < node->length(); ++i) {
ValueGraphVisitor for_value(owner(), temp_index());
node->ElementAt(i)->Visit(&for_value);
Append(for_value);
- PushArgument(for_value.value());
- values->Add(for_value.value());
+ arguments->Add(PushArgument(for_value.value()));
}
Value* element_type = BuildInstantiatedTypeArguments(node->token_pos(),
node->type_arguments());
CreateArrayComp* create = new CreateArrayComp(node->token_pos(),
owner()->try_index(),
- values,
+ arguments,
element_type);
ReturnComputation(create);
}
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698