Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10860007: Reland "Record the arguments for CreateArrayComp correctly as arguments.". (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 10878)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -1247,14 +1247,14 @@
public:
CreateArrayComp(intptr_t token_pos,
intptr_t try_index,
- ZoneGrowableArray<Value*>* elements,
+ ZoneGrowableArray<PushArgumentInstr*>* arguments,
Value* element_type)
: token_pos_(token_pos),
try_index_(try_index),
- elements_(elements) {
+ arguments_(arguments) {
#if defined(DEBUG)
- for (int i = 0; i < ElementCount(); ++i) {
- ASSERT(ElementAt(i) != NULL);
+ for (int i = 0; i < ArgumentCount(); ++i) {
+ ASSERT(ArgumentAt(i) != NULL);
}
ASSERT(element_type != NULL);
#endif
@@ -1263,12 +1263,11 @@
DECLARE_CALL_COMPUTATION(CreateArray)
- virtual intptr_t ArgumentCount() const { return ElementCount(); }
+ virtual intptr_t ArgumentCount() const { return arguments_->length(); }
intptr_t token_pos() const { return token_pos_; }
intptr_t try_index() const { return try_index_; }
- intptr_t ElementCount() const { return elements_->length(); }
- Value* ElementAt(intptr_t i) const { return (*elements_)[i]; }
+ PushArgumentInstr* ArgumentAt(intptr_t i) const { return (*arguments_)[i]; }
Value* element_type() const { return inputs_[0]; }
virtual void PrintOperandsTo(BufferFormatter* f) const;
@@ -1278,7 +1277,7 @@
private:
const intptr_t token_pos_;
const intptr_t try_index_;
- ZoneGrowableArray<Value*>* const elements_;
+ ZoneGrowableArray<PushArgumentInstr*>* const arguments_;
DISALLOW_COPY_AND_ASSIGN(CreateArrayComp);
};
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698