Implement super.foo = expression.

Implement super.foo = expression.

Committed: https://code.google.com/p/dart/source/detail?r=10798

[floitsch, 2012-08-15 18:20:47]

LGTM.

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1503: new
js.PropertyAccess.field(new js.This(), fieldName);
indent 4.

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1505: use(node.inputs[2]);
make this a getter with a telling name.

[ahe, 2012-08-15 19:10:49]

Thank you, Florian.

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1505: use(node.inputs[2]);
On 2012/08/15 18:20:47, floitsch wrote:
> make this a getter with a telling name.

How about:

get rhs {
  assert(isSetter);
  return inputs[2]; // one for this and one for…
}

[floitsch, 2012-08-15 19:26:31]

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
File dart/lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10854163/diff/1/dart/lib/compiler/impl...
dart/lib/compiler/implementation/ssa/codegen.dart:1505: use(node.inputs[2]);
On 2012/08/15 19:10:49, ahe wrote:
> On 2012/08/15 18:20:47, floitsch wrote:
> > make this a getter with a telling name.
> 
> How about:
> 
> get rhs {
>   assert(isSetter);
>   return inputs[2]; // one for this and one for…
> }

LGTM, but I don't see right now, why the value wouldn't be inputs[1]. But I
assume your comment would clear that up.
I would use the same getter-name as for HFieldSet ("value").

[ahe, 2012-08-15 20:01:01]

Hi Florian,

I found some issues while testing co19. Most notably, this is not handled yet:

--super.x

I'll submit this tomorrow, but please take another look.

Cheers,
Peter

[floitsch, 2012-08-15 20:53:40]

Still LGTM.