Implement super.foo = expression.

dart/lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 1481 matching lines @@
     if (superMethod.kind == ElementKind.FIELD) {
       ClassElement currentClass = work.element.getEnclosingClass();
       String fieldName;
       if (currentClass.isShadowedByField(superMethod)) {
         fieldName = compiler.namer.shadowedFieldName(superMethod);
       } else {
         LibraryElement library = superMethod.getLibrary();
         SourceString name = superMethod.name;
         fieldName = compiler.namer.instanceFieldName(library, name);
       }
-      push(new js.PropertyAccess.field(new js.This(), fieldName), node);
+      js.PropertyAccess access =
+        new js.PropertyAccess.field(new js.This(), fieldName);

[floitsch, 2012/08/15 18:20:47]

indent 4.

+      if (node.isSetter) {
+        use(node.inputs[2]);

[floitsch, 2012/08/15 18:20:47]

make this a getter with a telling name.

[ahe, 2012/08/15 19:10:49]

How about:

get rhs {
  assert(isSetter);
  return inputs[2]; // one for this and one for…
}

[floitsch, 2012/08/15 19:26:32]

LGTM, but I don't see right now, why the value wouldn't be inputs[1]. But I
assume your comment would clear that up.
I would use the same getter-name as for HFieldSet ("value").

+        push(new js.Assignment(access, pop()), node);
+      } else {
+        push(access, node);
+      }
     } else {
       String methodName;
       if (superMethod.kind == ElementKind.FUNCTION ||
           superMethod.kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
         methodName = compiler.namer.instanceMethodName(
             currentLibrary, superMethod.name, argumentCount);
       } else if (superMethod.kind == ElementKind.GETTER) {
         methodName =
             compiler.namer.getterName(currentLibrary, superMethod.name);
       } else {
@@ skipping 1370 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }