Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: dart/lib/compiler/implementation/ssa/nodes.dart

Issue 10854163: Implement super.foo = expression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments and fix a crash Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/lib/compiler/implementation/ssa/codegen.dart ('k') | dart/tests/co19/co19-dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/lib/compiler/implementation/ssa/nodes.dart
diff --git a/dart/lib/compiler/implementation/ssa/nodes.dart b/dart/lib/compiler/implementation/ssa/nodes.dart
index 1115943149f711d8db323f43b41a88c60dda0680..95031d4839b41ba7a0b3c859d9201f0ef79f4e48 100644
--- a/dart/lib/compiler/implementation/ssa/nodes.dart
+++ b/dart/lib/compiler/implementation/ssa/nodes.dart
@@ -1249,9 +1249,16 @@ class HInvokeStatic extends HInvoke {
}
class HInvokeSuper extends HInvokeStatic {
- HInvokeSuper(inputs) : super(inputs);
+ final bool isSetter;
+ HInvokeSuper(inputs, [this.isSetter = false]) : super(inputs);
toString() => 'invoke super: ${element.name}';
accept(HVisitor visitor) => visitor.visitInvokeSuper(this);
+
+ HInstruction get value() {
+ assert(isSetter);
+ // Index 0: the element, index 1: 'this'.
+ return inputs[2];
+ }
}
class HInvokeInterceptor extends HInvokeStatic {
« no previous file with comments | « dart/lib/compiler/implementation/ssa/codegen.dart ('k') | dart/tests/co19/co19-dart2js.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698