Issue 10854162: Move fixnum to from lib/ to pkg/ . Once pub.dartlang.org

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10854162: Move fixnum to from lib/ to pkg/ . Once pub.dartlang.org (Closed)

Created:
8 years, 4 months ago by dgrove

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom, Alan Knight

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Move fixnum to from lib/ to pkg/ . Once pub.dartlang.org is available, this package will likely be moved there. Committed: https://code.google.com/p/dart/source/detail?r=10769

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -2654 lines)			Patch
D	lib/fixnum/fixnum.dart	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	lib/fixnum/int32.dart	View	1 chunk	+0 lines, -354 lines	0 comments	Download
D	lib/fixnum/int64.dart	View	1 chunk	+0 lines, -1095 lines	0 comments	Download
D	lib/fixnum/intx.dart	View	1 chunk	+0 lines, -103 lines	0 comments	Download
A	pkg/fixnum/pubspec.yaml	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M +	pkg/fixnum/tests/int_32_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M +	pkg/fixnum/tests/int_64_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M +	pkg/fixnum/tests/int_64_vm_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/pkg.status	View	1 chunk	+2 lines, -0 lines	0 comments	Download
D	tests/lib/fixnum/int_32_test.dart	View	1 chunk	+0 lines, -158 lines	0 comments	Download
D	tests/lib/fixnum/int_64_test.dart	View	1 chunk	+0 lines, -606 lines	0 comments	Download
D	tests/lib/fixnum/int_64_vm_test.dart	View	1 chunk	+0 lines, -325 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years, 4 months ago (2012-08-15 20:19:05 UTC) #3

LGTM with an FYI.

https://chromiumcodereview.appspot.com/10854162/diff/1/pkg/fixnum/pubspec.yaml
File pkg/fixnum/pubspec.yaml (right):

https://chromiumcodereview.appspot.com/10854162/diff/1/pkg/fixnum/pubspec.yam...
pkg/fixnum/pubspec.yaml:4: dependencies:
You can omit the dependencies: line if it has none. Or you can leave it in.

Expand Messages | Collapse Messages