Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10843006: Remove the default contains_call parameter on location summaries. (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the default contains_call parameter on location summaries. The plan is to use this parameter to make finer distinctions between calls (e.g., safepoint vs. non-safepoint). It's a bit safer to eliminate the default. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10052

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -174 lines) Patch
M runtime/vm/assembler_ia32.cc View 1 chunk +1 line, -0 lines 1 comment Download
M runtime/vm/assembler_x64.cc View 1 chunk +1 line, -0 lines 1 comment Download
M runtime/vm/intermediate_language.cc View 1 10 chunks +23 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 37 chunks +82 lines, -75 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 39 chunks +88 lines, -76 lines 0 comments Download
M runtime/vm/locations.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/locations.cc View 1 3 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Google)
8 years, 4 months ago (2012-07-31 11:03:25 UTC) #1
Kevin Millikin (Google)
https://chromiumcodereview.appspot.com/10843006/diff/1/runtime/vm/locations.h File runtime/vm/locations.h (right): https://chromiumcodereview.appspot.com/10843006/diff/1/runtime/vm/locations.h#newcode52 runtime/vm/locations.h:52: enum ContainsCall { I moved this here because the ...
8 years, 4 months ago (2012-07-31 11:06:08 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://chromiumcodereview.appspot.com/10843006/diff/1/runtime/vm/locations.h File runtime/vm/locations.h (right): https://chromiumcodereview.appspot.com/10843006/diff/1/runtime/vm/locations.h#newcode52 runtime/vm/locations.h:52: enum ContainsCall { On 2012/07/31 11:06:09, kmillikin wrote: ...
8 years, 4 months ago (2012-07-31 11:21:26 UTC) #3
Ivan Posva
8 years, 4 months ago (2012-07-31 16:43:35 UTC) #4
https://chromiumcodereview.appspot.com/10843006/diff/5001/runtime/vm/assemble...
File runtime/vm/assembler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10843006/diff/5001/runtime/vm/assemble...
runtime/vm/assembler_ia32.cc:1411: // TODO(kmillikin): pass temp registers to
avoid pushing registers.
I have a different plan for this so please do not pass temp registers just yet.
We will invoke that solution (temp registers) if the others do not work.

https://chromiumcodereview.appspot.com/10843006/diff/5001/runtime/vm/assemble...
File runtime/vm/assembler_x64.cc (right):

https://chromiumcodereview.appspot.com/10843006/diff/5001/runtime/vm/assemble...
runtime/vm/assembler_x64.cc:1567: // TODO(kmillikin): pass temp registers to
avoid pushing registers.
ditto!

Powered by Google App Engine
This is Rietveld 408576698