Remove the default contains_call parameter on location summaries.

runtime/vm/locations.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_LOCATIONS_H_
 #define VM_LOCATIONS_H_
 
 #include "vm/allocation.h"
 #include "vm/assembler.h"
 #include "vm/bitfield.h"
@@ skipping 31 matching lines @@
 
     // Register location represents a fixed register.  Payload contains
     // register code.
     kRegister = 3,
 
     // Spill slot allocated by the register allocator.  Payload contains
     // a spill index.
     kStackSlot = 4,
   };
 
+  enum ContainsCall {

[Kevin Millikin (Google), 2012/07/31 11:06:09]

I moved this here because the name is shorter at the call sites :)

[Vyacheslav Egorov (Google), 2012/07/31 11:21:26]

But it is not a property of location, it's a property of location summary.
Please move back.

+    kNoCall,
+    kCall,
+  };
+
   enum {
     // Number of bits required to encode Kind value.
     kBitsForKind = 3,
-    kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind
+    kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind,
   };
 
   static const uword kInvalidLocation = 0;
   static const uword kConstantMask = 0x3;
 
   Location() : value_(kInvalidLocation) {
     ASSERT(IsInvalid());
   }
 
   bool IsInvalid() const {
@@ skipping 136 matching lines @@
   // Location either contains kind and payload fields or a tagged handle for
   // a constant locations. Values of enumeration Kind are selected in such a
   // way that none of them can be interpreted as a kConstant tag.
   uword value_;
 };
 
 
 // Specification of locations for inputs and output.
 class LocationSummary : public ZoneAllocated {
  public:
-  enum ContainsCall {
-    kNoCall,
-    kCall,
-  };
-
-  // TODO(vegorov): remove unsafe kNoCall default.
   LocationSummary(intptr_t input_count,
                   intptr_t temp_count,
-                  ContainsCall call = kNoCall);
+                  Location::ContainsCall contains_call);
 
   intptr_t input_count() const {
     return input_locations_.length();
   }
 
   Location in(intptr_t index) const {
     return input_locations_[index];
   }
 
   Location* in_slot(intptr_t index) {
@@ skipping 37 matching lines @@
   }
 
   bool is_call() const {
     return is_call_;
   }
 
   void PrintTo(BufferFormatter* f) const;
 
   static LocationSummary* Make(intptr_t input_count,
                                Location out,
-                               ContainsCall contains_call = kNoCall);
+                               Location::ContainsCall contains_call);
 
  private:
   // TODO(vegorov): replace with ZoneArray.
   GrowableArray<Location> input_locations_;
   GrowableArray<Location> temp_locations_;
   Location output_location_;
 
   const bool is_call_;
 };
 
 
 }  // namespace dart
 
 #endif  // VM_LOCATIONS_H_