Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Unified Diff: runtime/vm/locations.h

Issue 10843006: Remove the default contains_call parameter on location summaries. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rename. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/locations.h
diff --git a/runtime/vm/locations.h b/runtime/vm/locations.h
index 1393d312132253d2ee84c3782e35220854a7bc5d..c47a5603cf93715bbd8f5ddad7ad5451ffdb83ea 100644
--- a/runtime/vm/locations.h
+++ b/runtime/vm/locations.h
@@ -52,7 +52,7 @@ class Location : public ValueObject {
enum {
// Number of bits required to encode Kind value.
kBitsForKind = 3,
- kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind
+ kBitsForPayload = kWordSize * kBitsPerByte - kBitsForKind,
};
static const uword kInvalidLocation = 0;
@@ -214,10 +214,9 @@ class LocationSummary : public ZoneAllocated {
kCall,
};
- // TODO(vegorov): remove unsafe kNoCall default.
LocationSummary(intptr_t input_count,
intptr_t temp_count,
- ContainsCall call = kNoCall);
+ LocationSummary::ContainsCall contains_call);
intptr_t input_count() const {
return input_locations_.length();
@@ -275,7 +274,7 @@ class LocationSummary : public ZoneAllocated {
static LocationSummary* Make(intptr_t input_count,
Location out,
- ContainsCall contains_call = kNoCall);
+ LocationSummary::ContainsCall contains_call);
private:
// TODO(vegorov): replace with ZoneArray.

Powered by Google App Engine
This is Rietveld 408576698