Issue 10834017: Fix the definition of kIllegalPort in dart_api.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10834017: Fix the definition of kIllegalPort in dart_api.h. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 4 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix the definition of kIllegalPort in dart_api.h. Declaring a variable directly in a header will cause C to be unable to link multiple object files that both include that header, even if that variable is const. Committed: https://code.google.com/p/dart/source/detail?r=10135

Patch Set 1 #

Patch Set 2 : Use a #define to avoid undefined symbols in Dart extension shared objects. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -20 lines)			Patch
M	runtime/bin/directory.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/file.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/bin/socket.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/sample_extension/sample_extension.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

turnidge

8 years, 4 months ago (2012-07-31 20:23:21 UTC) #2

LGTM

You will need to coordinate with Anton when you submit this to make sure that
you do not break the dartium build.

Todd

Expand Messages | Collapse Messages