Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: runtime/bin/socket.cc

Issue 10834017: Fix the definition of kIllegalPort in dart_api.h. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Use a #define to avoid undefined symbols in Dart extension shared objects. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file.cc ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket.cc
diff --git a/runtime/bin/socket.cc b/runtime/bin/socket.cc
index 98992b57c92d34fc5c96c538d9a8adb949c879b4..1b2d407fbcad6483d59a60d6ded8ddfac1d1bdf6 100644
--- a/runtime/bin/socket.cc
+++ b/runtime/bin/socket.cc
@@ -320,16 +320,16 @@ Dart_Port Socket::GetServicePort() {
service_ports_ = new Dart_Port[service_ports_size_];
service_ports_index_ = 0;
for (int i = 0; i < service_ports_size_; i++) {
- service_ports_[i] = kIllegalPort;
+ service_ports_[i] = ILLEGAL_PORT;
}
}
Dart_Port result = service_ports_[service_ports_index_];
- if (result == kIllegalPort) {
+ if (result == ILLEGAL_PORT) {
result = Dart_NewNativePort("SocketService",
SocketService,
true);
- ASSERT(result != kIllegalPort);
+ ASSERT(result != ILLEGAL_PORT);
service_ports_[service_ports_index_] = result;
}
service_ports_index_ = (service_ports_index_ + 1) % service_ports_size_;
@@ -341,7 +341,7 @@ void FUNCTION_NAME(Socket_NewServicePort)(Dart_NativeArguments args) {
Dart_EnterScope();
Dart_SetReturnValue(args, Dart_Null());
Dart_Port service_port = Socket::GetServicePort();
- if (service_port != kIllegalPort) {
+ if (service_port != ILLEGAL_PORT) {
// Return a send port for the service port.
Dart_Handle send_port = Dart_NewSendPort(service_port);
Dart_SetReturnValue(args, send_port);
« no previous file with comments | « runtime/bin/file.cc ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698