runtime/vm/dart_api_impl_test.cc - Issue 10834017: Fix the definition of kIllegalPort in dart_api.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 10834017: Fix the definition of kIllegalPort in dart_api.h. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use a #define to avoid undefined symbols in Dart extension shared objects. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl_test.cc

diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc

index d9c7d9820690c3503d3d5bb4034990c8398f1ada..6875140dba0472744a619b5600da9e41102141b2 100644

--- a/runtime/vm/dart_api_impl_test.cc

+++ b/runtime/vm/dart_api_impl_test.cc

@@ -5606,7 +5606,7 @@ void NewNativePort_send321(Dart_Port dest_port_id,

UNIT_TEST_CASE(NewNativePort) {

// Create a port with a bogus handler.

Dart_Port error_port = Dart_NewNativePort("Foo", NULL, true);

- EXPECT_EQ(kIllegalPort, error_port);

+ EXPECT_EQ(ILLEGAL_PORT, error_port);

// Create the port w/o a current isolate, just to make sure that works.

Dart_Port port_id1 =

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | samples/sample_extension/sample_extension.cc » ('j') | no next file with comments »