Issue 10831314: Don't auto-send credentials on XHR.get

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10831314: Don't auto-send credentials on XHR.get (Closed)

Created:
8 years, 4 months ago by vsm

Modified:
8 years, 4 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, terry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't auto-send credentials on XHR.get I've introduced an alternative XHR.getWithCredentials to make this an explicit opt-in. BUG=4481 Committed: https://code.google.com/p/dart/source/detail?r=10683

Patch Set 1 #

Patch Set 2 : Fix test status for dart2js #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -175 lines)			Patch
M	lib/dom/src/_XMLHttpRequestUtils.dart	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	lib/dom/templates/html/dart2js/factoryprovider_XMLHttpRequest.darttemplate	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/dom/templates/html/dartium/factoryprovider_XMLHttpRequest.darttemplate	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	lib/dom/templates/html/interface/interface_XMLHttpRequest.darttemplate	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View		3 chunks	+10 lines, -7 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		4 chunks	+19 lines, -16 lines	0 comments	Download
D	lib/html/src/XMLHttpRequestWrappingImplementation.dart	View		1 chunk	+0 lines, -131 lines	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/html/xhr_cross_origin_test.dart	View		1 chunk	+42 lines, -0 lines	1 comment	Download
M	tests/html/xhr_test.dart	View		1 chunk	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

8 years, 4 months ago (2012-08-14 21:44:18 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10831314/diff/2001/tests/html/xhr_cros...
File tests/html/xhr_cross_origin_test.dart (right):

https://chromiumcodereview.appspot.com/10831314/diff/2001/tests/html/xhr_cros...
tests/html/xhr_cross_origin_test.dart:41: });
Add a comment saying why there is not getWithCredentials test

Expand Messages | Collapse Messages