Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: lib/html/dart2js/html_dart2js.dart

Issue 10831314: Don't auto-send credentials on XHR.get (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix test status for dart2js Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: lib/html/dart2js/html_dart2js.dart
diff --git a/lib/html/dart2js/html_dart2js.dart b/lib/html/dart2js/html_dart2js.dart
index a831b38598910f34fd308f0ae96d7611088b6974..57b16e128d3c48d0b5afc291cc8dc70318b35fcf 100644
--- a/lib/html/dart2js/html_dart2js.dart
+++ b/lib/html/dart2js/html_dart2js.dart
@@ -17804,7 +17804,11 @@ class _XMLHttpRequestFactoryProvider {
factory XMLHttpRequest.get(String url,
onSuccess(XMLHttpRequest request)) =>
- _XMLHttpRequestUtils.get(url, onSuccess);
+ _XMLHttpRequestUtils.get(url, onSuccess, false);
+
+ factory XMLHttpRequest.getWithCredentials(String url,
+ onSuccess(XMLHttpRequest request)) =>
+ _XMLHttpRequestUtils.get(url, onSuccess, true);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -35931,10 +35935,10 @@ interface WorkerNavigator {
/// @domName XMLHttpRequest
interface XMLHttpRequest extends EventTarget default _XMLHttpRequestFactoryProvider {
- // TODO(rnystrom): This name should just be "get" which is valid in Dart, but
- // not correctly implemented yet. (b/4970173)
XMLHttpRequest.get(String url, onSuccess(XMLHttpRequest request));
+ XMLHttpRequest.getWithCredentials(String url, onSuccess(XMLHttpRequest request));
+
XMLHttpRequest();
/**
@@ -36934,13 +36938,12 @@ class _XMLHttpRequestUtils {
// Helper for factory XMLHttpRequest.get
static XMLHttpRequest get(String url,
- onSuccess(XMLHttpRequest request)) {
+ onSuccess(XMLHttpRequest request),
+ bool withCredentials) {
final request = new XMLHttpRequest();
request.open('GET', url, true);
- // TODO(terry): Validate after client login added if necessary to forward
- // cookies to server.
- request.withCredentials = true;
+ request.withCredentials = withCredentials;
// Status 0 is for local XHR request.
request.on.readyStateChange.add((e) {

Powered by Google App Engine
This is Rietveld 408576698