Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: lib/html/dartium/html_dartium.dart

Issue 10831314: Don't auto-send credentials on XHR.get (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix test status for dart2js Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: lib/html/dartium/html_dartium.dart
diff --git a/lib/html/dartium/html_dartium.dart b/lib/html/dartium/html_dartium.dart
index 8f13b284a9eb387f431705c73359f288856ab965..9a2a26168c41c57da2bb88cb277482fe51f881b0 100644
--- a/lib/html/dartium/html_dartium.dart
+++ b/lib/html/dartium/html_dartium.dart
@@ -20641,7 +20641,11 @@ class _XMLHttpRequestFactoryProvider {
factory XMLHttpRequest.get(String url,
onSuccess(XMLHttpRequest request)) =>
- _XMLHttpRequestUtils.get(url, onSuccess);
+ _XMLHttpRequestUtils.get(url, onSuccess, false);
+
+ factory XMLHttpRequest.getWithCredentials(String url,
+ onSuccess(XMLHttpRequest request)) =>
+ _XMLHttpRequestUtils.get(url, onSuccess, true);
}
class _XMLHttpRequestEventsImpl extends _EventsImpl implements XMLHttpRequestEvents {
@@ -39288,10 +39292,10 @@ interface WorkerNavigator {
/// @domName XMLHttpRequest
interface XMLHttpRequest extends EventTarget default _XMLHttpRequestFactoryProvider {
- // TODO(rnystrom): This name should just be "get" which is valid in Dart, but
- // not correctly implemented yet. (b/4970173)
XMLHttpRequest.get(String url, onSuccess(XMLHttpRequest request));
+ XMLHttpRequest.getWithCredentials(String url, onSuccess(XMLHttpRequest request));
+
XMLHttpRequest();
/**
@@ -40291,13 +40295,12 @@ class _XMLHttpRequestUtils {
// Helper for factory XMLHttpRequest.get
static XMLHttpRequest get(String url,
- onSuccess(XMLHttpRequest request)) {
+ onSuccess(XMLHttpRequest request),
+ bool withCredentials) {
final request = new XMLHttpRequest();
request.open('GET', url, true);
- // TODO(terry): Validate after client login added if necessary to forward
- // cookies to server.
- request.withCredentials = true;
+ request.withCredentials = withCredentials;
// Status 0 is for local XHR request.
request.on.readyStateChange.add((e) {
@@ -41204,21 +41207,21 @@ class _Deserializer {
// This API is exploratory.
spawnDomFunction(Function topLevelFunction) => _Utils.spawnDomFunctionImpl(topLevelFunction);
-// layoutTestController implementation.
-// FIXME: provide a separate lib for layoutTestController.
+// testRunner implementation.
+// FIXME: provide a separate lib for testRunner.
-var _layoutTestController;
+var _testRunner;
-LayoutTestController get layoutTestController() {
- if (_layoutTestController === null)
- _layoutTestController = new LayoutTestController._(_NPObject.retrieve("layoutTestController"));
- return _layoutTestController;
+TestRunner get testRunner() {
+ if (_testRunner === null)
+ _testRunner = new TestRunner._(_NPObject.retrieve("testRunner"));
+ return _testRunner;
}
-class LayoutTestController {
+class TestRunner {
final _NPObject _npObject;
- LayoutTestController._(this._npObject);
+ TestRunner._(this._npObject);
display() => _npObject.invoke('display');
dumpAsText() => _npObject.invoke('dumpAsText');

Powered by Google App Engine
This is Rietveld 408576698