Issue 10828318: Disable using CompileType for class check elimination.

Issue 10828318: Disable using CompileType for class check elimination. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disable using CompileType for class check elimination. Committed: https://code.google.com/p/dart/source/detail?r=10694

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediate_language.cc#newcode1045 runtime/vm/intermediate_language.cc:1045: // TODO(srdjan): Do not use CompileType, as it ...

8 years, 4 months ago (2012-08-15 00:11:46 UTC) #2

srdjan

8 years, 4 months ago (2012-08-15 00:16:46 UTC) #3

https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:1045: // TODO(srdjan): Do not use
CompileType, as it is not correct.
On 2012/08/15 00:11:46, regis wrote:
> CompileType is not wrong. As I explained, it just cannot guarantee that an
> instance is not null. For that, we would need value propagation. Or you may
need
> to emit null checks. Let's discuss.

Oops. I realized that and changed the text to:

  // TODO(srdjan): Do not use CompileType for class check elimination.

https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_ia32.cc:503: // TODO(srdjan): CompileType does
not give us correct type for optimizations.
On 2012/08/15 00:11:46, regis wrote:
> Does not guarantee that the receiver is not null.

That is the same.

https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10828318/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language_x64.cc:513: // TODO(srdjan): CompileType does
not give us correct type for optimziations.
On 2012/08/15 00:11:46, regis wrote:
> s/optimziations/certain optimizations/

Done.

Expand Messages | Collapse Messages