Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10828318: Disable using CompileType for class check elimination. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 10687)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -1042,6 +1042,7 @@
Definition* StrictCompareComp::TryReplace(BindInstr* instr) {
+ // TODO(srdjan): Do not use CompileType for class check elimination.
return NULL;
UseVal* left_use = left()->AsUse();
UseVal* right_use = right()->AsUse();
@@ -1053,7 +1054,6 @@
if (right_constant == NULL) return NULL;
// TODO(fschneider): Handle other cases: e === false and e !== true/false.
// Handles e === true.
- // const AbstractType& left_type = AbstractType::Handle(left->CompileType());
if ((kind() == Token::kEQ_STRICT) &&
(right_constant->value().raw() == Bool::True()) &&
left_use->CompileTypeIsMoreSpecificThan(
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698