Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 10828318: Disable using CompileType for class check elimination. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "lib/error.h" 10 #include "lib/error.h"
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 __ pushq(left); 503 __ pushq(left);
504 __ pushq(right); 504 __ pushq(right);
505 EmitEqualityAsPolymorphicCall(compiler, ic_data, locs, branch, kind, 505 EmitEqualityAsPolymorphicCall(compiler, ic_data, locs, branch, kind,
506 deopt_id, token_pos, try_index, 506 deopt_id, token_pos, try_index,
507 locs.stack_bitmap()); 507 locs.stack_bitmap());
508 __ Bind(&done); 508 __ Bind(&done);
509 } 509 }
510 510
511 511
512 static intptr_t GetCid(const Value& v) { 512 static intptr_t GetCid(const Value& v) {
513 const AbstractType& type = AbstractType::Handle(v.CompileType()); 513 // TODO(srdjan): CompileType does not give us correct type for optimziations.
regis 2012/08/15 00:11:46 s/optimziations/certain optimizations/
srdjan 2012/08/15 00:16:46 Done.
514 return Class::Handle(type.type_class()).id(); 514 // const AbstractType& type = AbstractType::Handle(v.CompileType());
515 // return Class::Handle(type.type_class()).id();
516 return kIllegalCid;
515 } 517 }
516 518
517 519
518 static void EmitSmiComparisonOp(FlowGraphCompiler* compiler, 520 static void EmitSmiComparisonOp(FlowGraphCompiler* compiler,
519 const LocationSummary& locs, 521 const LocationSummary& locs,
520 Token::Kind kind, 522 Token::Kind kind,
521 BranchInstr* branch, 523 BranchInstr* branch,
522 intptr_t deopt_id, 524 intptr_t deopt_id,
523 intptr_t token_pos, 525 intptr_t token_pos,
524 intptr_t try_index) { 526 intptr_t try_index) {
(...skipping 1703 matching lines...) Expand 10 before | Expand all | Expand 10 after
2228 locs()->stack_bitmap()); 2230 locs()->stack_bitmap());
2229 __ CompareObject(RAX, compiler->bool_true()); 2231 __ CompareObject(RAX, compiler->bool_true());
2230 EmitBranchOnCondition(compiler, branch_condition); 2232 EmitBranchOnCondition(compiler, branch_condition);
2231 } 2233 }
2232 2234
2233 } // namespace dart 2235 } // namespace dart
2234 2236
2235 #undef __ 2237 #undef __
2236 2238
2237 #endif // defined TARGET_ARCH_X64 2239 #endif // defined TARGET_ARCH_X64
OLDNEW
« runtime/vm/intermediate_language_ia32.cc ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698