Issue 10827028: Print out browser version number also for Windows bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827028: Print out browser version number also for Windows bots. (Closed)

Created:
8 years, 5 months ago by Emily Fortuna

Modified:
8 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Print out browser version number also for Windows bots. Committed: https://code.google.com/p/dart/source/detail?r=9924

Patch Set 1 : #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	utils/compiler/buildbot.py	View		1 chunk	+13 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Some more information on this: Windows GUI swallows the version info when we query the ...

8 years, 5 months ago (2012-07-26 00:46:00 UTC) #2

Siggi Cherem (dart-lang)

lgtm? https://chromiumcodereview.appspot.com/10827028/diff/4001/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10827028/diff/4001/utils/compiler/buildbot.py#newcode228 utils/compiler/buildbot.py:228: version_query_string += '| more' I didn't know that ...

8 years, 5 months ago (2012-07-26 00:50:11 UTC) #3

Emily Fortuna

for reference, I'll happily replace this code with anything nicer that works (key words being ...

8 years, 5 months ago (2012-07-26 00:54:16 UTC) #4

Jennifer Messerly

8 years, 5 months ago (2012-07-26 17:33:10 UTC) #5

On 2012/07/26 00:54:16, Emily Fortuna wrote:
> for reference, I'll happily replace this code with anything nicer that works
> (key words being "that works")

lgtm. Or at least, looks as good as Windows code can look :)

Expand Messages | Collapse Messages