Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: utils/compiler/buildbot.py

Issue 10827028: Print out browser version number also for Windows bots. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/compiler/buildbot.py
===================================================================
--- utils/compiler/buildbot.py (revision 9897)
+++ utils/compiler/buildbot.py (working copy)
@@ -223,10 +223,21 @@
elif (runtime == 'ff' or runtime == 'chrome') and is_buildbot:
# Print out browser version numbers if we're running on the buildbot (where
# we know the paths to these browser installations).
- p = subprocess.Popen('%s --version' % GetPath(runtime),
+ version_query_string = '%s --version' % GetPath(runtime)
+ if runtime == 'ff' and system == 'win7':
+ version_query_string += '| more'
Siggi Cherem (dart-lang) 2012/07/26 00:50:11 I didn't know that '| more' was valid in win
+ elif runtime == 'chrome' and system == 'win7':
+ version_query_string = ('''reg query "HKCU\\Software\\Microsoft\\''' +
+ '''Windows\\CurrentVersion\\Uninstall\\Google Chrome" \\v Version''')
Siggi Cherem (dart-lang) 2012/07/26 00:50:11 AAAH! wow...
+ p = subprocess.Popen(version_query_string,
stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
output, stderr = p.communicate()
- print 'Version of %s: %s' % (runtime, output)
+ output = output.split()
+ try:
+ print 'Version of %s: %s' % (runtime, output[-1])
+ except IndexError:
+ # Failed to obtain version information. Continue running tests.
+ pass
if compiler == 'dart2js':
if option == 'checked': flags = flags + ['--host-checked']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698