Print out browser version number also for Windows bots.

utils/compiler/buildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart frog buildbot steps
 
 Runs tests for the frog or dart2js compiler.
 """
@@ skipping 205 matching lines @@
           'chrome': os.path.join('C:/', 'Users', 'chrome-bot', 'AppData',
           'Local', 'Google', 'Chrome', 'Application', 'chrome.exe')}
     return path_dict[runtime]
 
   if system == 'linux' and runtime == 'chrome':
     # TODO(ngeoffray): We should install selenium on the buildbot.
     runtime = 'drt'
   elif (runtime == 'ff' or runtime == 'chrome') and is_buildbot:
     # Print out browser version numbers if we're running on the buildbot (where
     # we know the paths to these browser installations).
-    p = subprocess.Popen('%s --version' % GetPath(runtime),
+    version_query_string = '%s --version' % GetPath(runtime)
+    if runtime == 'ff' and system == 'win7':
+      version_query_string += '| more'

[Siggi Cherem (dart-lang), 2012/07/26 00:50:11]

I didn't know that '| more' was valid in win

+    elif runtime == 'chrome' and system == 'win7':
+      version_query_string = ('''reg query "HKCU\\Software\\Microsoft\\''' + 
+          '''Windows\\CurrentVersion\\Uninstall\\Google Chrome" \\v Version''')

[Siggi Cherem (dart-lang), 2012/07/26 00:50:11]

AAAH! wow...

+    p = subprocess.Popen(version_query_string,
         stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True)
     output, stderr = p.communicate()
-    print 'Version of %s: %s' % (runtime, output)
+    output = output.split()
+    try:
+      print 'Version of %s: %s' % (runtime, output[-1])
+    except IndexError:
+      # Failed to obtain version information. Continue running tests.
+      pass
 
   if compiler == 'dart2js':
     if option == 'checked': flags = flags + ['--host-checked']
 
     if runtime == 'd8':
       # The dart2js compiler isn't self-hosted (yet) so we run its
       # unit tests on the VM. We avoid doing this on the builders
       # that run the browser tests to cut down on the cycle time.
       TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'], flags)
 
@@ skipping 92 matching lines @@
   if status == 0 and option != 'checked' and runtime == 'd8':
     status = TestCompiler(compiler, runtime, mode, system, option,
                           test_flags + ['--checked'], is_buildbot)
 
   if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
   if status != 0: print '@@@STEP_FAILURE@@@'
   return status
 
 if __name__ == '__main__':
   sys.exit(main())