Improve the stack trace output to be more readable.

Improve the stack trace output to be more readable.

BEFORE

Unhandled exception:
MyException
 0. Function: '::baz' url: 'file:///Users/turnidge/dart/bug.dart' line:2 col:3
 1. Function: '_OtherClass@11f7ef14._OtherClass@11f7ef14._named@11f7ef14' url: 'file:///Users/turnidge/dart/bug.dart' line:7 col:8
 2. Function: '::set:globalVar' url: 'file:///Users/turnidge/dart/bug.dart' line:12 col:3
 3. Function: '::_bar@11f7ef14' url: 'file:///Users/turnidge/dart/bug.dart' line:16 col:3
 4. Function: 'MyClass.get:field' url: 'file:///Users/turnidge/dart/bug.dart' line:25 col:9
 5. Function: 'MyClass.fooHelper' url: 'file:///Users/turnidge/dart/bug.dart' line:30 col:7
 6. Function: 'MyClass.foo' url: 'file:///Users/turnidge/dart/bug.dart' line:32 col:14
 7. Function: 'MyClass.function' url: 'file:///Users/turnidge/dart/bug.dart' line:21 col:15
 8. Function: 'MyClass.MyClass.' url: 'file:///Users/turnidge/dart/bug.dart' line:21 col:18
 9. Function: '::function' url: 'file:///Users/turnidge/dart/bug.dart' line:38 col:10
 10. Function: '::main' url: 'file:///Users/turnidge/dart/bug.dart' line:38 col:24

AFTER

Unhandled exception:
MyException
#0      baz (file:///Users/turnidge/dart/bug.dart:2:3)
#1      _OtherClass._OtherClass._named (file:///Users/turnidge/dart/bug.dart:7:8)
#2      globalVar= (file:///Users/turnidge/dart/bug.dart:12:3)
#3      _bar (file:///Users/turnidge/dart/bug.dart:16:3)
#4      MyClass.field (file:///Users/turnidge/dart/bug.dart:25:9)
#5      MyClass.foo.fooHelper (file:///Users/turnidge/dart/bug.dart:30:7)
#6      MyClass.foo (file:///Users/turnidge/dart/bug.dart:32:14)
#7      MyClass.MyClass.<anonymous closure> (file:///Users/turnidge/dart/bug.dart:21:15)
#8      MyClass.MyClass (file:///Users/turnidge/dart/bug.dart:21:18)
#9      main.<anonymous closure> (file:///Users/turnidge/dart/bug.dart:38:10)
#10     main (file:///Users/turnidge/dart/bug.dart:38:24)
Committed: https://code.google.com/p/dart/source/detail?r=10408

[siva, 2012-08-07 21:41:37]

lgtm

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode109
vm/object.cc:109: // Internal getter and setter prefices are removed:
prefixes

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode112
vm/object.cc:112: //   set:foo -> foo
I am wondering get:foo should become 'get foo' and
set:foo converted to 'set foo' in order to match the source code and have some
way of differentiating setters from getters. What do you think?

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode154
vm/object.cc:154: result = String::SubString(name, start, (limit - start));
const String& result = String::Handle(String::Sub.......)
like the suffix setting below?

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode4452
vm/object.cc:4452: tmp = String::Concat(tmp, suffix);
See comment above regarding setter/gettter, does it make sense to match the
source code?

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode11023
vm/object.cc:11023: const char* kFormat = "    at %s (%s:%d:%d)\n";
Looking at the sample output you have attached I am not sure adding the 'at'
string to the stack trace adds any value.

Also I was wondering if we have recursive calls then it might be useful to have
the frame number in the trace as it provides a reference number.

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object_test.cc
File vm/object_test.cc (right):

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object_test.cc#newc...
vm/object_test.cc:2858: "    at baz (dart:test-lib:2:3)\n"
There seems to be too many ':' characters do you think it would be better if you
just had
(dart:test-lib 2:3)

[turnidge, 2012-08-07 23:32:09]

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode109
vm/object.cc:109: // Internal getter and setter prefices are removed:
On 2012/08/07 21:41:37, asiva wrote:
> prefixes

Done.

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode112
vm/object.cc:112: //   set:foo -> foo
Discussed offline.  For now this lets me share the pretty name with the
embedding api, mirrors, and stack traces.  From talking with Gilad, I believe
that foo= will be the official name for the setter from a spec perspective.  For
now we will commit is as is and change it if it is confusing.

On 2012/08/07 21:41:37, asiva wrote:
> I am wondering get:foo should become 'get foo' and
> set:foo converted to 'set foo' in order to match the source code and have some
> way of differentiating setters from getters. What do you think?

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode154
vm/object.cc:154: result = String::SubString(name, start, (limit - start));
On 2012/08/07 21:41:37, asiva wrote:
> const String& result = String::Handle(String::Sub.......)
> like the suffix setting below?

Done.

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode4452
vm/object.cc:4452: tmp = String::Concat(tmp, suffix);
On 2012/08/07 21:41:37, asiva wrote:
> See comment above regarding setter/gettter, does it make sense to match the
> source code?

See above.

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object.cc#newcode11023
vm/object.cc:11023: const char* kFormat = "    at %s (%s:%d:%d)\n";
Replaced "at" with a frame number.

On 2012/08/07 21:41:37, asiva wrote:
> Looking at the sample output you have attached I am not sure adding the 'at'
> string to the stack trace adds any value.
> 
> Also I was wondering if we have recursive calls then it might be useful to
have
> the frame number in the trace as it provides a reference number.

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object_test.cc
File vm/object_test.cc (right):

https://chromiumcodereview.appspot.com/10826191/diff/1/vm/object_test.cc#newc...
vm/object_test.cc:2858: "    at baz (dart:test-lib:2:3)\n"
Discussed offline.  Will leave as is.

On 2012/08/07 21:41:37, asiva wrote:
> There seems to be too many ':' characters do you think it would be better if
you
> just had
> (dart:test-lib 2:3)