Improve the stack trace output to be more readable.

vm/object_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
@@ skipping 2790 matching lines @@
   bare_name = OneByteString::New("foo.name");
   EXPECT(!mangled_name.EqualsIgnoringPrivateKey(bare_name));
 }
 
 
 TEST_CASE(ArrayNew_Overflow_Crash) {
   Array::Handle(Array::New(Array::kMaxElements + 1));
 }
 
 
+TEST_CASE(StackTraceFormat) {
+  const char* kScriptChars =
+      "void baz() {\n"
+      "  throw 'MyException';\n"
+      "}\n"
+      "\n"
+      "class _OtherClass {\n"
+      "  _OtherClass._named() {\n"
+      "    baz();\n"
+      "  }\n"
+      "}\n"
+      "\n"
+      "set globalVar(var value) {\n"
+      "  new _OtherClass._named();\n"
+      "}\n"
+      "\n"
+      "void _bar() {\n"
+      "  globalVar = null;\n"
+      "}\n"
+      "\n"
+      "class MyClass {\n"
+      "  MyClass() {\n"
+      "    (() => foo())();\n"
+      "  }\n"
+      "\n"
+      "  static get field() {\n"
+      "    _bar();\n"
+      "  }\n"
+      "\n"
+      "  static foo() {\n"
+      "    fooHelper() {\n"
+      "      field;\n"
+      "    }\n"
+      "    fooHelper();\n"
+      "  }\n"
+      "}\n"
+      "\n"
+      "main() {\n"
+      "  (() => new MyClass())();\n"
+      "}\n";
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  EXPECT_VALID(lib);
+  Dart_Handle result = Dart_Invoke(lib, Dart_NewString("main"), 0, NULL);
+  EXPECT_ERROR(
+      result,
+      "Unhandled exception:\n"
+      "MyException\n"
+      "    at baz (dart:test-lib:2:3)\n"

[siva, 2012/08/07 21:41:37]

There seems to be too many ':' characters do you think it would be better if you
just had
(dart:test-lib 2:3)

[turnidge, 2012/08/07 23:32:09]

Discussed offline.  Will leave as is.

On 2012/08/07 21:41:37, asiva wrote:

+      "    at _OtherClass._OtherClass._named (dart:test-lib:7:8)\n"
+      "    at globalVar= (dart:test-lib:12:3)\n"
+      "    at _bar (dart:test-lib:16:3)\n"
+      "    at MyClass.field (dart:test-lib:25:9)\n"
+      "    at MyClass.foo.fooHelper (dart:test-lib:30:7)\n"
+      "    at MyClass.foo (dart:test-lib:32:14)\n"
+      "    at MyClass.MyClass.<anonymous closure> (dart:test-lib:21:15)\n"
+      "    at MyClass.MyClass (dart:test-lib:21:18)\n"
+      "    at main.<anonymous closure> (dart:test-lib:37:10)\n"
+      "    at main (dart:test-lib:37:24)");
+}
+
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart