Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: platform/assert.cc

Issue 10826191: Improve the stack trace output to be more readable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tests/vm/dart/isolate_mirror_local_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 6
7 #include <cstdlib> 7 #include <cstdlib>
8 #include <sstream> 8 #include <sstream>
9 #include <string> 9 #include <string>
10 10
11 #include "platform/globals.h" 11 #include "platform/globals.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 // Exit with a failure code when we miss an EXPECT check. 15 // Exit with a failure code when we miss an EXPECT check.
16 static void failed_exit(void) { 16 static void failed_exit(void) {
17 exit(255); 17 exit(255);
18 } 18 }
19 19
20 void DynamicAssertionHelper::Fail(const char* format, ...) { 20 void DynamicAssertionHelper::Fail(const char* format, ...) {
21 std::stringstream stream; 21 std::stringstream stream;
22 stream << file_ << ":" << line_ << ": error: "; 22 stream << file_ << ":" << line_ << ": error: ";
23 23
24 va_list arguments; 24 va_list arguments;
25 va_start(arguments, format); 25 va_start(arguments, format);
26 char buffer[KB]; 26 char buffer[2 * KB];
27 vsnprintf(buffer, sizeof(buffer), format, arguments); 27 vsnprintf(buffer, sizeof(buffer), format, arguments);
28 va_end(arguments); 28 va_end(arguments);
29 stream << buffer << std::endl; 29 stream << buffer << std::endl;
30 30
31 // Get the message from the string stream and dump it on stderr. 31 // Get the message from the string stream and dump it on stderr.
32 std::string message = stream.str(); 32 std::string message = stream.str();
33 fprintf(stderr, "%s", message.c_str()); 33 fprintf(stderr, "%s", message.c_str());
34 34
35 // In case of failed assertions, abort right away. Otherwise, wait 35 // In case of failed assertions, abort right away. Otherwise, wait
36 // until the program is exiting before producing a non-zero exit 36 // until the program is exiting before producing a non-zero exit
37 // code through abort. 37 // code through abort.
38 // TODO(5411324): replace std::abort with OS::Abort so that we can handle 38 // TODO(5411324): replace std::abort with OS::Abort so that we can handle
39 // restoring of signal handlers before aborting. 39 // restoring of signal handlers before aborting.
40 if (kind_ == ASSERT) { 40 if (kind_ == ASSERT) {
41 std::abort(); 41 std::abort();
42 } 42 }
43 static bool failed = false; 43 static bool failed = false;
44 if (!failed) { 44 if (!failed) {
45 std::atexit(&failed_exit); 45 std::atexit(&failed_exit);
46 } 46 }
47 failed = true; 47 failed = true;
48 } 48 }
49 49
50 } // namespace dart 50 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | tests/vm/dart/isolate_mirror_local_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698