Fix the archive code so that it compiles in a stricter mode.

Fix the archive code so that it compiles in a stricter mode.

Committed: https://code.google.com/p/dart/source/detail?r=10362

[Bob Nystrom, 2012-08-07 22:58:43]

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/messaging.c
File utils/archive/messaging.c (right):

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/messagin...
utils/archive/messaging.c:124: return 0; // Should never reach this point.
Can you use assert.h (or something else) and assert this?

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/messagin...
utils/archive/messaging.c:146: *module = *name = *value = NULL;
Nit, but I find chained assignments like this hard to read and not that helpful
if the RHS is just a literal. Can you break this into separate statements?

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/reader.dart
File utils/archive/reader.dart (right):

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/reader.d...
utils/archive/reader.dart:128: var addOption = (request, option) {
Function statement instead of expression:

addOption(request, option) { ... }

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/reader.d...
utils/archive/reader.dart:129: var value;;
Double ;;

[nweiz, 2012-08-07 23:06:59]

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/messaging.c
File utils/archive/messaging.c (right):

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/messagin...
utils/archive/messaging.c:124: return 0; // Should never reach this point.
On 2012/08/07 22:58:43, Bob Nystrom wrote:
> Can you use assert.h (or something else) and assert this?

It's already effectively asserted on line 121, above.

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/messagin...
utils/archive/messaging.c:146: *module = *name = *value = NULL;
On 2012/08/07 22:58:43, Bob Nystrom wrote:
> Nit, but I find chained assignments like this hard to read and not that
helpful
> if the RHS is just a literal. Can you break this into separate statements?

Done.

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/reader.dart
File utils/archive/reader.dart (right):

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/reader.d...
utils/archive/reader.dart:128: var addOption = (request, option) {
On 2012/08/07 22:58:43, Bob Nystrom wrote:
> Function statement instead of expression:
> 
> addOption(request, option) { ... }

Done.

https://chromiumcodereview.appspot.com/10824210/diff/1/utils/archive/reader.d...
utils/archive/reader.dart:129: var value;;
On 2012/08/07 22:58:43, Bob Nystrom wrote:
> Double ;;

Done.

[Bob Nystrom, 2012-08-07 23:16:18]

LGTM!