Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: utils/archive/reader.c

Issue 10824210: Fix the archive code so that it compiles in a stricter mode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Small fixes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/archive/reader.h ('k') | utils/archive/reader.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/archive/reader.c
diff --git a/utils/archive/reader.c b/utils/archive/reader.c
index bd016c547ab12baa7c813d2497b2558833f44573..00a7db37098586efd88f14158bacaeaddc691969 100644
--- a/utils/archive/reader.c
+++ b/utils/archive/reader.c
@@ -93,27 +93,36 @@ void archiveReadSupportFormatZip(Dart_Port p, struct archive* a) {
checkResult(p, a, archive_read_support_format_zip(a));
}
-void archiveReadSetFilterOptions(Dart_Port p, struct archive* a,
- Dart_CObject* request) {
- Dart_CObject* options = getTypedArgument(p, request, 0, kString);
- if (options == NULL) return;
- int result = archive_read_set_filter_options(a, options->value.as_string);
+void archiveReadSetFilterOption(Dart_Port p, struct archive* a,
+ Dart_CObject* request) {
+ char* module;
+ char* name;
+ char* value;
+
+ getOptionArguments(p, request, &module, &name, &value);
+ int result = archive_read_set_filter_option(a, module, name, value);
checkResult(p, a, result);
}
void archiveReadSetFormatOptions(Dart_Port p, struct archive* a,
Dart_CObject* request) {
- Dart_CObject* options = getTypedArgument(p, request, 0, kString);
- if (options == NULL) return;
- int result = archive_read_set_format_options(a, options->value.as_string);
+ char* module;
+ char* name;
+ char* value;
+
+ getOptionArguments(p, request, &module, &name, &value);
+ int result = archive_read_set_format_option(a, module, name, value);
checkResult(p, a, result);
}
void archiveReadSetOptions(Dart_Port p, struct archive* a,
Dart_CObject* request) {
- Dart_CObject* options = getTypedArgument(p, request, 0, kString);
- if (options == NULL) return;
- int result = archive_read_set_options(a, options->value.as_string);
+ char* module;
+ char* name;
+ char* value;
+
+ getOptionArguments(p, request, &module, &name, &value);
+ int result = archive_read_set_option(a, module, name, value);
checkResult(p, a, result);
}
« no previous file with comments | « utils/archive/reader.h ('k') | utils/archive/reader.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698