Fix the archive code so that it compiles in a stricter mode.

utils/archive/messaging.c

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <errno.h>
 #include <stdarg.h>
 
 #include "messaging.h"
 
 void postResult(Dart_Port p, bool success, int err, Dart_CObject* response) {
@@ skipping 38 matching lines @@
 
   DART_NULL(null_response);
   postResult(p, true, 0, &null_response);
 }
 
 bool checkError(Dart_Port p, struct archive* a, int result) {
   if (result == ARCHIVE_OK) return false;
   // TODO(nweiz): What should we do about non-fatal warnings?
   if (result == ARCHIVE_WARN) return false;
   postError(p, a);
+  return true;
 }
 
 bool checkPointerError(Dart_Port p, void* pointer, char* name) {
   if (pointer != NULL) return false;
   char buffer[100];
   snprintf(buffer, 100, "Failed to allocate memory for %s.", name);
   DART_STRING(error_string, buffer);
   postResult(p, false, ENOMEM, &error_string);
   return true;
 }
@@ skipping 44 matching lines @@
   if (arg->type == kInt32) return arg;
   postInvalidArgument(p, "Invalid argument %d: expected integer, was type %d.",
     i+1, arg->type);
   return NULL;
 }
 
 int64_t getInteger(Dart_CObject* object) {
   assert(object->type == kInt64 || object->type == kInt32);
   if (object->type == kInt64) return object->value.as_int64;
   if (object->type == kInt32) return (int64_t) object->value.as_int32;
+  return 0; // Should never reach this point.
 }
 
 Dart_CObject* getNullableStringArgument(Dart_Port p, Dart_CObject* request,
     int i) {
   Dart_CObject* arg = getArgument(p, request, i);
   if (arg == NULL) return NULL;
   if (arg->type == kNull) return arg;
   if (arg->type == kString) return arg;
   postInvalidArgument(p, "Invalid argument %d: expected string or null, was " \
     "type %d.", i+1, arg->type);
   return NULL;
 }
 
 char* getNullableString(Dart_CObject* object) {
   assert(object->type == kNull || object->type == kString);
   if (object->type == kString) return object->value.as_string;
   return NULL;
 }
+
+bool getOptionArguments(Dart_Port p, Dart_CObject* request, char** module,
+    char** name, char** value) {
+  *module = *name = *value = NULL;
+
+  Dart_CObject* wrappedModule = getNullableStringArgument(p, request, 0);
+  if (wrappedModule == NULL) return false;
+  *module = getNullableString(wrappedModule);
+
+  Dart_CObject* wrappedName = getTypedArgument(p, request, 0, kString);
+  if (wrappedName == NULL) return false;
+  *name = wrappedName->value.as_string;
+
+  Dart_CObject* wrappedValue = getNullableStringArgument(p, request, 0);
+  if (wrappedValue == NULL) return false;
+  *value = getNullableString(wrappedValue);
+
+  return true;
+}
+