Issue 10808035: Apply Kevin's suggestions, make branch-compare generation more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10808035: Apply Kevin's suggestions, make branch-compare generation more robust (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google), Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Apply Kevin's suggestions, make branch-compare generation more robust - remove setting previous link during graph building - do not replace already inserted nodes Committed: https://code.google.com/p/dart/source/detail?r=9778

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+168 lines, -110 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 2 3 4	2 chunks	+8 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4	3 chunks	+62 lines, -58 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	11 chunks	+46 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	11 chunks	+46 lines, -22 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGMT as well

Expand Messages | Collapse Messages