Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 10808035: Apply Kevin's suggestions, make branch-compare generation more robust (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
===================================================================
--- runtime/vm/flow_graph_builder.h (revision 9777)
+++ runtime/vm/flow_graph_builder.h (working copy)
@@ -315,8 +315,7 @@
: ValueGraphVisitor(owner, temp_index),
true_successor_address_(NULL),
false_successor_address_(NULL),
- condition_token_pos_(condition_token_pos) {
- }
+ condition_token_pos_(condition_token_pos) { }
TargetEntryInstr** true_successor_address() const {
ASSERT(true_successor_address_ != NULL);
@@ -334,6 +333,13 @@
// Closes the fragment and sets the output parameters.
virtual void ReturnValue(Value* value);
+ // Either merges the computation into BranchInstr (Comparison, BooleanNegate)
+ // or adds a Bind instruction to the graph and returns its temporary value.
+ virtual void ReturnComputation(Computation* computation);
+
+ void MergeBranchWithComparison(ComparisonComp* comp);
+ void MergeBranchWithNegate(BooleanNegateComp* comp);
+
// Output parameters.
TargetEntryInstr** true_successor_address_;
TargetEntryInstr** false_successor_address_;
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698