Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: runtime/vm/intermediate_language.h

Issue 10808035: Apply Kevin's suggestions, make branch-compare generation more robust (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 9777)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -618,12 +618,15 @@
public:
EqualityCompareComp(intptr_t token_pos,
intptr_t try_index,
+ Token::Kind kind,
Value* left,
Value* right)
- : ComparisonComp(Token::kEQ, left, right),
+ : ComparisonComp(kind, left, right),
token_pos_(token_pos),
try_index_(try_index),
- receiver_class_id_(kObject) {}
+ receiver_class_id_(kObject) {
+ ASSERT((kind == Token::kEQ) || (kind == Token::kNE));
+ }
DECLARE_COMPUTATION(EqualityCompare)
@@ -1762,9 +1765,6 @@
// to append instruction in case of a Throw inside an expression. This
// condition should be handled in the graph builder
next_ = instr;
- if ((instr != NULL) && !instr->IsBlockEntry()) {
- instr->set_previous(this);
- }
}
// Normal instructions can have 0 (inside a block) or 1 (last instruction in
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698