Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 10797031: Add missing type finalization for function literals not assigned to a function (Closed)

Created:
8 years, 5 months ago by regis
Modified:
8 years, 5 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add missing type finalization for function literals not assigned to a function variable. Various cleanup. Committed: https://code.google.com/p/dart/source/detail?r=9782

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -59 lines) Patch
M runtime/bin/builtin_natives.cc View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 1 chunk +1 line, -10 lines 0 comments Download
M runtime/vm/object.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 2 chunks +21 lines, -25 lines 0 comments Download
M tests/language/comparison_test.dart View 1 2 1 chunk +12 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
8 years, 5 months ago (2012-07-19 18:02:04 UTC) #1
srdjan
8 years, 5 months ago (2012-07-20 00:20:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698