Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: runtime/vm/intermediate_language.cc

Issue 10797031: Add missing type finalization for function literals not assigned to a function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc (revision 9780)
+++ runtime/vm/intermediate_language.cc (working copy)
@@ -788,16 +788,7 @@
RawAbstractType* CreateClosureComp::StaticType() const {
const Function& fun = function();
const Class& signature_class = Class::Handle(fun.signature_class());
- // TODO(regis): The signature type may be generic. Consider upper bounds.
- // For now, we return Dynamic (no type test elimination) if the signature
- // class is parameterized, or a non-parameterized finalized type otherwise.
- if (signature_class.HasTypeArguments()) {
- return Type::DynamicType();
- }
- // Make sure we use the canonical signature class.
- const Type& type = Type::Handle(signature_class.SignatureType());
- const Class& canonical_signature_class = Class::Handle(type.type_class());
- return Type::NewNonParameterizedType(canonical_signature_class);
+ return signature_class.SignatureType();
}
« no previous file with comments | « runtime/bin/builtin_natives.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698