Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: runtime/bin/builtin_natives.cc

Issue 10797031: Add missing type finalization for function literals not assigned to a function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/builtin_natives.cc
===================================================================
--- runtime/bin/builtin_natives.cc (revision 9780)
+++ runtime/bin/builtin_natives.cc (working copy)
@@ -88,14 +88,9 @@
int num_entries = sizeof(BuiltinEntries) / sizeof(struct NativeEntries);
for (int i = 0; i < num_entries; i++) {
struct NativeEntries* entry = &(BuiltinEntries[i]);
- if (!strcmp(function_name, entry->name_)) {
- if (entry->argument_count_ == argument_count) {
- return reinterpret_cast<Dart_NativeFunction>(entry->function_);
- } else {
- // Wrong number of arguments.
- // TODO(regis): Should we pass a buffer for error reporting?
- return NULL;
- }
+ if (!strcmp(function_name, entry->name_) &&
+ (entry->argument_count_ == argument_count)) {
+ return reinterpret_cast<Dart_NativeFunction>(entry->function_);
}
}
return NULL;
« no previous file with comments | « no previous file | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698