Issue 10702195: Equality compare should record two arguments in IC data. INline double equality comparison.

Issue 10702195: Equality compare should record two arguments in IC data. INline double equality comparison. (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Equality compare should record two arguments in IC data. Inline double equality comparison. Committed: https://code.google.com/p/dart/source/detail?r=9644

Patch Set 6 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+225 lines, -110 lines)			Patch
M	runtime/vm/code_generator.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	3 chunks	+12 lines, -40 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4 5	2 chunks	+28 lines, -12 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3	1 chunk	+6 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	8 chunks	+46 lines, -27 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	8 chunks	+49 lines, -29 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10702195/diff/12001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://chromiumcodereview.appspot.com/10702195/diff/12001/runtime/vm/flow_graph_compiler.cc#newcode472 runtime/vm/flow_graph_compiler.cc:472: void FlowGraphCompiler::EmitDoubleCompareBranch(Condition true_condition, How about a comment mentioning ...

8 years, 5 months ago (2012-07-13 20:07:53 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/10702195/diff/12001/runtime/vm/flow_graph_compiler.cc File runtime/vm/flow_graph_compiler.cc (right): https://chromiumcodereview.appspot.com/10702195/diff/12001/runtime/vm/flow_graph_compiler.cc#newcode472 runtime/vm/flow_graph_compiler.cc:472: void FlowGraphCompiler::EmitDoubleCompareBranch(Condition true_condition, On 2012/07/13 20:07:53, regis wrote: > ...

8 years, 5 months ago (2012-07-13 20:29:11 UTC) #3

Expand Messages | Collapse Messages