Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: runtime/vm/il_printer.cc

Issue 10702195: Equality compare should record two arguments in IC data. INline double equality comparison. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/il_printer.cc
===================================================================
--- runtime/vm/il_printer.cc (revision 9640)
+++ runtime/vm/il_printer.cc (working copy)
@@ -82,10 +82,35 @@
}
+static void PrintICData(BufferFormatter* f, const ICData& ic_data) {
+ f->Print(" IC[%d: ", ic_data.NumberOfChecks());
+ Function& target = Function::Handle();
+ for (intptr_t i = 0; i < ic_data.NumberOfChecks(); i++) {
+ GrowableArray<intptr_t> class_ids;
+ ic_data.GetCheckAt(i, &class_ids, &target);
+ if (i > 0) {
+ f->Print(" | ");
+ }
+ for (intptr_t k = 0; k < class_ids.length(); k++) {
+ if (k > 0) {
+ f->Print(", ");
+ }
+ const Class& cls =
+ Class::Handle(Isolate::Current()->class_table()->At(class_ids[k]));
+ f->Print("%s", String::Handle(cls.Name()).ToCString());
+ }
+ }
+ f->Print("]");
+}
+
+
void Computation::PrintTo(BufferFormatter* f) const {
- f->Print("%s(", DebugName());
+ f->Print("%s:%d(", DebugName(), cid());
PrintOperandsTo(f);
f->Print(")");
+ if (HasICData()) {
+ PrintICData(f, *ic_data());
+ }
}
@@ -146,18 +171,9 @@
f->Print("%s(", DebugName());
instance_call()->PrintOperandsTo(f);
f->Print(") ");
- intptr_t len = HasICData() ? ic_data()->NumberOfChecks() : 0;
- f->Print("[%d: ", len);
- for (intptr_t i = 0; i < len; i++) {
- intptr_t class_id = ic_data()->GetReceiverClassIdAt(i);
- const Class& cls =
- Class::Handle(Isolate::Current()->class_table()->At(class_id));
- if (i > 0) {
- f->Print(", ");
- }
- f->Print("%s", cls.ToCString());
+ if (HasICData()) {
+ PrintICData(f, *ic_data());
}
- f->Print("]");
}
void StrictCompareComp::PrintOperandsTo(BufferFormatter* f) const {
« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698