Equality compare should record two arguments in IC data. INline double equality comparison.

runtime/vm/flow_graph_compiler.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_XXX.
 
 #include "vm/flow_graph_compiler.h"
 
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
@@ skipping 451 matching lines @@
     }
     assembler()->Bind(&next_test);
   }
   assembler()->Bind(&match_found);
   if (done != NULL) {
     assembler()->jmp(done);
   }
 }
 
 
+void FlowGraphCompiler::EmitDoubleCompareBranch(Condition true_condition,

[regis, 2012/07/13 20:07:53]

How about a comment mentioning the potential branch to nan_result?

[srdjan, 2012/07/13 20:29:11]

Discussed offline: nan_result is either ture or false target

+                                                XmmRegister left,
+                                                XmmRegister right,
+                                                BranchInstr* branch) {
+  ASSERT(branch != NULL);
+  assembler()->comisd(left, right);
+  BlockEntryInstr* nan_result = branch->is_negated() ?
+      branch->true_successor() : branch->false_successor();
+  assembler()->j(PARITY_EVEN, GetBlockLabel(nan_result));
+  branch->EmitBranchOnCondition(this, true_condition);
+}
+
+
 
+void FlowGraphCompiler::EmitDoubleCompareBool(Condition true_condition,
+                                              XmmRegister left,
+                                              XmmRegister right,
+                                              Register result) {
+  assembler()->comisd(left, right);
+  Label is_false, is_true, done;
+  assembler()->j(PARITY_EVEN, &is_false, Assembler::kNearJump);  // NaN false;
+  assembler()->j(true_condition, &is_true, Assembler::kNearJump);
+  assembler()->Bind(&is_false);
+  assembler()->LoadObject(result, bool_false());
+  assembler()->jmp(&done);
+  assembler()->Bind(&is_true);
+  assembler()->LoadObject(result, bool_true());
+  assembler()->Bind(&done);
+}
 
 
 Register FrameRegisterAllocator::AllocateFreeRegister(bool* blocked_registers) {
   for (intptr_t regno = 0; regno < kNumberOfCpuRegisters; regno++) {
     if (!blocked_registers[regno] && (registers_[regno] == NULL)) {
       blocked_registers[regno] = true;
       return static_cast<Register>(regno);
     }
   }
   return SpillFirst();
@@ skipping 281 matching lines @@
       return;
     }
   }
 
   // This move is not blocked.
   EmitMove(index);
 }
 
 
 }  // namespace dart