Issue 10699027: Flag uninitialized final variables in a class.

Issue 10699027: Flag uninitialized final variables in a class. (Closed)

Created:
8 years, 5 months ago by zundel

Modified:
8 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, scheglov

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Flag uninitialized final variables in a class. Issue 3655 : http://code.google.com/p/dart/issues/detail?id=3655 Committed: https://code.google.com/p/dart/source/detail?r=9233

Patch Set 1 : # #

Total comments: 4

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -28 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/Modifiers.java	View	4 chunks	+4 lines, -0 lines	2 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	5 chunks	+45 lines, -11 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View	7 chunks	+11 lines, -10 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	3 chunks	+71 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM http://codereview.chromium.org/10699027/diff/4001/compiler/java/com/google/dart/compiler/ast/Modifiers.java File compiler/java/com/google/dart/compiler/ast/Modifiers.java (right): http://codereview.chromium.org/10699027/diff/4001/compiler/java/com/google/dart/compiler/ast/Modifiers.java#newcode1 compiler/java/com/google/dart/compiler/ast/Modifiers.java:1: // Copyright (c) 2011, the Dart project authors. ...

8 years, 5 months ago (2012-06-28 21:53:53 UTC) #2

zundel

8 years, 5 months ago (2012-06-28 22:07:15 UTC) #3

http://codereview.chromium.org/10699027/diff/4001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/ast/Modifiers.java (right):

http://codereview.chromium.org/10699027/diff/4001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/ast/Modifiers.java:1: // Copyright (c)
2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/28 21:53:53, Brian Wilkerson wrote:
> nit: copyright year

Done.

http://codereview.chromium.org/10699027/diff/4001/compiler/java/com/google/da...
File
compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java
(right):

http://codereview.chromium.org/10699027/diff/4001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/resolver/FieldElementImplementation.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
On 2012/06/28 21:53:53, Brian Wilkerson wrote:
> nit: copyright year

Done.

Expand Messages | Collapse Messages