Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java

Issue 10699027: Flag uninitialized final variables in a class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: # Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java b/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
index 589eb473666452ca6dc190cc3e0c09b4bbab3231..55d192ec007e833ce5b19afeb0d819aebd6f7761 100644
--- a/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
+++ b/compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
@@ -3,9 +3,6 @@
// BSD-style license that can be found in the LICENSE file.
package com.google.dart.compiler.resolver;
-import static com.google.dart.compiler.common.ErrorExpectation.assertErrors;
-import static com.google.dart.compiler.common.ErrorExpectation.errEx;
-
import com.google.dart.compiler.CompilerTestCase;
import com.google.dart.compiler.DartCompilationError;
import com.google.dart.compiler.ast.DartFunctionTypeAlias;
@@ -16,6 +13,9 @@ import com.google.dart.compiler.common.ErrorExpectation;
import com.google.dart.compiler.testing.TestCompilerContext;
import com.google.dart.compiler.type.Type;
+import static com.google.dart.compiler.common.ErrorExpectation.assertErrors;
+import static com.google.dart.compiler.common.ErrorExpectation.errEx;
+
import java.util.ArrayList;
import java.util.List;
@@ -30,13 +30,13 @@ public class NegativeResolverTest extends CompilerTestCase {
resolve(unit);
assertErrors(errors, expectedErrors);
}
-
+
public void checkSourceErrorsAsSystemLibrary(String source, ErrorExpectation... expectedErrors) {
DartUnit unit = parseUnitAsSystemLibrary("Test.dart", source);
resolve(unit);
assertErrors(errors, expectedErrors);
- }
-
+ }
+
/**
* Parses given Dart file, runs {@link Resolver} and checks that expected errors were generated.
@@ -443,7 +443,7 @@ public class NegativeResolverTest extends CompilerTestCase {
"duplicate top-level declaration 'FIELD foo' at Test.dart::2:5",
errors.get(1).getMessage());
}
-
+
/**
* Shadowing top-level element with local variable.
* <p>
@@ -475,7 +475,7 @@ public class NegativeResolverTest extends CompilerTestCase {
"Local variable 'foo' is hiding 'FIELD foo' at Test.dart::4:5",
errors.get(2).getMessage());
}
-
+
/**
* Shadowing top-level element with local variable.
* <p>
@@ -1112,7 +1112,8 @@ public class NegativeResolverTest extends CompilerTestCase {
" var x;",
"}"),
errEx(ResolverErrorCode.CONST_CLASS_WITH_NONFINAL_FIELDS, 3, 7, 1),
- errEx(ResolverErrorCode.CONST_CLASS_WITH_INHERITED_NONFINAL_FIELDS, 9, 7, 3));
+ errEx(ResolverErrorCode.CONST_CLASS_WITH_INHERITED_NONFINAL_FIELDS, 9, 7, 3),
+ errEx(ResolverErrorCode.FINAL_FIELD_MUST_BE_INITIALIZED, 8, 9, 3));
}
private TestCompilerContext getContext() {
@@ -1300,7 +1301,7 @@ public class NegativeResolverTest extends CompilerTestCase {
Type boundType = typeParameter.getBound().getType();
assertEquals("A", boundType.getElement().getName());
}
-
+
public void test_methodCannotBeResolved() throws Exception {
checkSourceErrors(
makeCode(

Powered by Google App Engine
This is Rietveld 408576698