Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3326)

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 10699027: Flag uninitialized final variables in a class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: # Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
index 07cd57e203e59a95b159f1ed509a69ac708eb77d..9e8dbbe91479203415c60aac4f0257d5120ebf7c 100644
--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java
@@ -350,6 +350,9 @@ public class MemberBuilder {
// types of constant expressions.
modifiers = modifiers.makeConstant();
}
+ if (fieldNode.getValue() != null) {
+ modifiers = modifiers.makeInitialized();
+ }
FieldNodeElement fieldElement = fieldNode.getElement();
if (fieldElement == null) {
fieldElement = Elements.fieldFromNode(fieldNode, currentHolder, modifiers);

Powered by Google App Engine
This is Rietveld 408576698