Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 10690074: Migrates some resolver errors to parser stage (Closed)

Created:
8 years, 5 months ago by zundel
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Migrates some resolver errors to parser stage I found some resolver errors I could not reproduce because they were not reachable code (parser wouldn't accept them). Since we have discussed running the analysis server in stages where parsing might be done first, it made sense to me to move some error reporting into the parser anywy. I also tried to make the messages more friendly. Committed: https://code.google.com/p/dart/source/detail?r=9361

Patch Set 1 #

Total comments: 1

Patch Set 2 : # #

Messages

Total messages: 2 (0 generated)
zundel
8 years, 5 months ago (2012-07-03 15:57:21 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-07-03 16:06:37 UTC) #2
LGTM

https://chromiumcodereview.appspot.com/10690074/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java (right):

https://chromiumcodereview.appspot.com/10690074/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:79:
FACTORY_CANNOT_BE_TOPLEVEL("A factory cannot be toplevel, it must be a member of
a class"),
nit: "toplevel" --> "top level"

Powered by Google App Engine
This is Rietveld 408576698