compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java - Issue 10690074: Migrates some resolver errors to parser stage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

Issue 10690074: Migrates some resolver errors to parser stage (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: # Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

index f81d61f32ef839e949390cc49b9fff76def422d0..f636a9eb9ecdbd2a075fb07dd6a0f100088c2838 100644

--- a/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/MemberBuilder.java

@@ -569,13 +569,6 @@ public class MemberBuilder {

}

if (modifiers.isFactory()) {

- if (modifiers.isStatic()) {

- resolutionError(method.getName(), ResolverErrorCode.FACTORY_CANNOT_BE_STATIC);

- }

- if (modifiers.isAbstract()) {

- resolutionError(method.getName(), ResolverErrorCode.FACTORY_CANNOT_BE_ABSTRACT);

- }

if (modifiers.isConstant()) {

// Allow const factory ... native ... ; type of constructors, used in core libraries

DartBlock dartBlock = method.getFunction().getBody();